Hi Vasilii, Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls Regards, Sergey On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss < discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
Greetings, Sergey! Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR? I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well. Or maybe there are better options that I don't know about. Thank you for response. Best regards, Vasilii 19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss <discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
Vasilii, Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests. Regards, Sergey On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <qobood@gmail.com> wrote:
Greetings, Sergey!
Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR?
I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well.
Or maybe there are better options that I don't know about. Thank you for response.
Best regards, Vasilii
19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss < discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
Vasilii, Great that you come with a typo fixing PR, thank you! Taking a random spot-check when trying to improve our capability to work with contributors, I was particularly amenable to your contribution – as fixing typos is easy enough. I have the following review notes – perhaps you can use them already when you supply your PR? -If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually. +If the changes are not amendable to automated testing, please explain why not and carefully describe how to test manually. Nope, "amenable" is the correct, intended word. But we want "easy" words (not likely to be misunderstood). So I suggest: amen(d)able -> suitable +# * Accessebility Check # Accessebility -> Accessibility + Check a file or path for accessebility. Accessebility -> Accessibility + conversion is garanteed to be less than 251, which occupies garanteed -> guaranteed + /* wsrep_sst_*.sh scripts requite ipv6 addresses to be in square breackets */ breackets -> brackets Then for the "non-English" texts. They are in Swedish, my native tongue. Here are the proper translations -Speciella användbara nya string-rutiner: +Speciella anv�ndbara nya string-rutiner: Special, useful new string routines: - - Används istället för ctype.h för att klara internationella karakterer. + - Anv�nds ist�llet f�r ctype.h f�r att klara internationella karakterer. Is used instead of ctype.h to handle international characters - Använd instället för string.h för att supporta snabbare strängfunktioner. + Anv�nd inst�llet f�r string.h f�r att supporta snabbare str�ngfunktioner. Use instead of string.h to support faster string functions - - Använd inte strcat, använd strmov (se ovan). + - Anv�nd inte strcat, anv�nd strmov (se ovan). Do not use strcat, use strmov (see above) Kaj Den ons 19 feb. 2025 kl 19:06 skrev Sergey Vojtovich via discuss < discuss@lists.mariadb.org>:
Vasilii,
Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests.
Regards, Sergey
On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <qobood@gmail.com> wrote:
Greetings, Sergey!
Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR?
I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well.
Or maybe there are better options that I don't know about. Thank you for response.
Best regards, Vasilii
19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss < discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
_______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
-- Kaj Arnö, CEO MariaDB Foundation | @mariadb_org | +358-45-1589296 | @kajarno
Greetings, Sergey! I've made the pull request, that covers sql/: https://github.com/MariaDB/server/pull/3882 It's approximately 70% of all typos I've found throughout the C comments, whole list contains ~1200 changes. Please let me know if you have any remarks. Best regards, Vasilii On 2/19/25 20:05, Sergey Vojtovich wrote:
Vasilii,
Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests.
Regards, Sergey
On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <qobood@gmail.com> wrote:
Greetings, Sergey!
Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR?
I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well.
Or maybe there are better options that I don't know about. Thank you for response.
Best regards, Vasilii 19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss <discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
Greetings, Sergey! I've made two more PRs, covering storage/: https://github.com/MariaDB/server/pull/3911 and other files: https://github.com/MariaDB/server/pull/3912 And with that i'm done with typos in C comments. Thank you for your time and attention. Best regards, Vasilii On 3/9/25 19:48, Vasilii Lakhin wrote:
Greetings, Sergey!
I've made the pull request, that covers sql/: https://github.com/MariaDB/server/pull/3882 It's approximately 70% of all typos I've found throughout the C comments, whole list contains ~1200 changes. Please let me know if you have any remarks.
Best regards, Vasilii
On 2/19/25 20:05, Sergey Vojtovich wrote:
Vasilii,
Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests.
Regards, Sergey
On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <qobood@gmail.com> wrote:
Greetings, Sergey!
Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR?
I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well.
Or maybe there are better options that I don't know about. Thank you for response.
Best regards, Vasilii 19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss <discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
Greetings, Sergey! I've made yet another PR that covers comments inside */mysql-test/* : https://github.com/MariaDB/server/pull/3952 I've seen main.timezone test failing, but as far as I know I didn't touch it. There are ~200 more miscellaneous typos i've found, I'll create a separate PR for them soon. Once again, thank you for your time and attention. Best regards, Vasilii On 3/22/25 16:07, Vasilii Lakhin wrote:
Greetings, Sergey!
I've made two more PRs, covering
storage/: https://github.com/MariaDB/server/pull/3911 and other files: https://github.com/MariaDB/server/pull/3912
And with that i'm done with typos in C comments. Thank you for your time and attention.
Best regards, Vasilii
On 3/9/25 19:48, Vasilii Lakhin wrote:
Greetings, Sergey!
I've made the pull request, that covers sql/: https://github.com/MariaDB/server/pull/3882 It's approximately 70% of all typos I've found throughout the C comments, whole list contains ~1200 changes. Please let me know if you have any remarks.
Best regards, Vasilii
On 2/19/25 20:05, Sergey Vojtovich wrote:
Vasilii,
Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests.
Regards, Sergey
On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <qobood@gmail.com> wrote:
Greetings, Sergey!
Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR?
I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well.
Or maybe there are better options that I don't know about. Thank you for response.
Best regards, Vasilii 19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss <discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org
Hi Vasilii! Have you considered contributing spell checking to the CI system? You one-off spelling fix sprint may regress in 1-2 years unless there is CI in place to prevent new typos from being introduced. What tool are you using? Can that be hooked into CI to check all new lines of code in commits?
Greetings, Otto! I use simple bash script, that makes a list with all unique words (or, rather, entities) inside the whole source tree, and then I look through that list semi-manually, sometimes picking out words nearby. Running this script for two different states and diff-ing two files has decent result, although resulting list of unique words still needs to be looked through, as it contains a lot of entities which neither are really words or typos. (I've found a decent amount of typos made between 49a6baec and bb9f0104, for example "acces", "afile") This script in theory should also be able to find unique/deleted identifiers/functions/e.t.c., although I myself didn't find any yet. The script itself looks like that: find . -type f \! -path 'unwanted_path' \! -name 'unwanted_name' \ -exec grep -o -P '\b[a-zA-Z_][a-zA-Z0-9-_]+' {} \; | ... | sort | uniq -u Sorry I've kept you waiting. Best regards, Vasilii
участники (5)
-
Kaj Arnö -
Lakhin Vasilii -
Otto Kekäläinen -
Sergey Vojtovich -
Vasilii Lakhin