Hi, Vladislav, Note, despite what the subject says, below is not for one commit, but for the diff over them all. Just a couple of questions and a comment:

diff --git a/libmariadb b/libmariadb index a6665e65c05..22f7ed12b46 160000 --- a/libmariadb +++ b/libmariadb @@ -1 +1 @@ -Subproject commit a6665e65c05c00f9df983a0f788a643ca7bc084c +Subproject commit 22f7ed12b4645a9fc5d66974551359373090c86b

are auth_gssapi plugins using only standard Windows libraries?

diff --git a/mysql-test/main/mysql_install_db_win_utf8.test b/mysql-test/main/mysql_install_db_win_utf8.test index fc67b66d3ca..0dc75af3914 100644 --- a/mysql-test/main/mysql_install_db_win_utf8.test +++ b/mysql-test/main/mysql_install_db_win_utf8.test @@ -1,6 +1,6 @@ --source include/windows.inc --source include/check_utf8_cli.inc - +use mysql;

Why?

# Create database in tmp directory using mysql_install_db.exe, # and start server from this directory. let $ddir= $MYSQLTEST_VARDIR/tmp/датадир; diff --git a/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm b/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm index e77ba05cb5c..71a6bf33b7b 100644 --- a/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm +++ b/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm @@ -1,8 +1,9 @@ + package My::Suite::AuthGSSAPI;

@ISA = qw(My::Suite);

-return "No AUTH_GSSAPI plugin" unless $ENV{AUTH_GSSAPI_SO}; +return "No AUTH_GSSAPI plugin" unless ($ENV{AUTH_GSSAPI_SO} or ($^O eq 'MSWin32'));

The second condition normally is something like or $::mysqld_variables{gssapi} eq "ON";

return "Not run for embedded server" if $::opt_embedded_server;

Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org