Hi Serg,

Q1:

are auth_gssapi plugins using only standard Windows libraries?

Yes, just standard Windows API  (SSPI). It has been there for a long time , since Windows 2000 at least

Q2:

> --- a/mysql-test/main/mysql_install_db_win_utf8.test

> +++ b/mysql-test/main/mysql_install_db_win_utf8.test

> @@ -1,6 +1,6 @@

>  --source include/windows.inc

>  --source include/check_utf8_cli.inc

> -

> +use mysql;

Why?

Because if I do not do that, I get an error, after reconnect, after installing via  mysql_install_db.exe  and reconnect . It is like this

2022-09-13 18:51:19 0 [Note] C:\work\10.11\xxx\sql\Debug\mysqld.exe (server 10.11.0-MariaDB-debug) starting as process 26204 ...

mysqltest: In included file "./include/wait_until_connected_again.inc":

included from ./include/start_mysqld.inc at line 42:

included from C:/work/10.11/mysql-test/main/mysql_install_db_win.test at line 11:

At line 15: query 'select 1' failed with wrong errno ER_BAD_DB_ERROR (1049): 'Unknown database 'test'', instead of  (0).

Interesting is that this error is new, and I have not seen it in the past.  But it is legit.  mysql_install_db.exe  does not create  test db, so reconnect should actually fail, although perhaps  ‘SELECT 1’ would need a valid database. I did not debug why it suddenly appeared (new C/C?), but as I mentioned, it looks legitimate.

Q3:

> +return "No AUTH_GSSAPI plugin" unless ($ENV{AUTH_GSSAPI_SO} or ($^O eq 'MSWin32'));

The second condition normally is something like

  or $::mysqld_variables{gssapi} eq "ON";

Right, this looks much better.  I’ve change it this way.

Best,

Wlad

From: Sergei Golubchik
Sent: Sunday, September 11, 2022 6:08 PM
To: Vladislav Vaintroub
Cc: maria-developers@lists.launchpad.net
Subject: Re: [Maria-developers] e0e75de899f: MDEV-26715 Windows/installer - allow passwordless login for root

Hi, Vladislav,

Note, despite what the subject says, below is not for one commit, but

for the diff over them all.

Just a couple of questions and a comment:

> diff --git a/libmariadb b/libmariadb

> index a6665e65c05..22f7ed12b46 160000

> --- a/libmariadb

> +++ b/libmariadb

> @@ -1 +1 @@

> -Subproject commit a6665e65c05c00f9df983a0f788a643ca7bc084c

> +Subproject commit 22f7ed12b4645a9fc5d66974551359373090c86b

are auth_gssapi plugins using only standard Windows libraries?

> diff --git a/mysql-test/main/mysql_install_db_win_utf8.test b/mysql-test/main/mysql_install_db_win_utf8.test

> index fc67b66d3ca..0dc75af3914 100644

> --- a/mysql-test/main/mysql_install_db_win_utf8.test

> +++ b/mysql-test/main/mysql_install_db_win_utf8.test

> @@ -1,6 +1,6 @@

>  --source include/windows.inc

>  --source include/check_utf8_cli.inc

> -

> +use mysql;

Why?

>  # Create database  in tmp directory using mysql_install_db.exe,

>  # and start server from this directory.

>  let $ddir= $MYSQLTEST_VARDIR/tmp/датадир;

> diff --git a/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm b/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm

> index e77ba05cb5c..71a6bf33b7b 100644

> --- a/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm

> +++ b/plugin/auth_gssapi/mysql-test/auth_gssapi/suite.pm

> @@ -1,8 +1,9 @@

> +

>  package My::Suite::AuthGSSAPI;

> 

>  @ISA = qw(My::Suite);

> 

> -return "No AUTH_GSSAPI plugin" unless $ENV{AUTH_GSSAPI_SO};

> +return "No AUTH_GSSAPI plugin" unless ($ENV{AUTH_GSSAPI_SO} or ($^O eq 'MSWin32'));

The second condition normally is something like

  or $::mysqld_variables{gssapi} eq "ON";

> 

>  return "Not run for embedded server" if $::opt_embedded_server;

> 

Regards,

Sergei

VP of MariaDB Server Engineering

and security@mariadb.org

_______________________________________________

Mailing list: https://launchpad.net/~maria-developers

Post to     : maria-developers@lists.launchpad.net

Unsubscribe : https://launchpad.net/~maria-developers

More help   : https://help.launchpad.net/ListHelp