Re: [Maria-developers] MDEV-10101 Wrong error message of SELECT 1 UNION (SELECT 1 FROM t1 GROUP BY 1 WITH ROLLUP)

Hi, Alexander! On May 25, Alexander Barkov wrote:

Please review a patch for MDEV-10101.

diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy index ab66905..d6c34cd 100644 --- a/sql/sql_yacc.yy +++ b/sql/sql_yacc.yy @@ -737,13 +737,6 @@ bool setup_select_in_parentheses(LEX *lex) my_parse_error(lex->thd, ER_SYNTAX_ERROR); return TRUE; } - if (sel->linkage == UNION_TYPE && - sel->olap != UNSPECIFIED_OLAP_TYPE && - sel->master_unit()->fake_select_lex) - { - my_error(ER_WRONG_USAGE, MYF(0), "CUBE/ROLLUP", "ORDER BY"); - return TRUE; - } return FALSE; }

ok to push Regards, Sergei Chief Architect MariaDB and security@mariadb.org