Hi, Sergey! On Jul 29, Sergey Vojtovich wrote:
diff --git a/sql/share/errmsg-utf8.txt b/sql/share/errmsg-utf8.txt index 6954170..374e31f 100644 --- a/sql/share/errmsg-utf8.txt +++ b/sql/share/errmsg-utf8.txt @@ -7111,3 +7111,6 @@ ER_SLAVE_SKIP_NOT_IN_GTID eng "When using GTID, @@sql_slave_skip_counter can not be used. Instead, setting @@gtid_slave_pos explicitly can be used to skip to after a given GTID position." ER_TABLE_DEFINITION_TOO_BIG eng "The definition for table %`s is too big" +ER_PLUGIN_EXISTS + eng "Plugin '%-.192s' already exists" + rus "Плагин '%-.192s' уже существует"
May be "already installed" ? The command is INSTALL PLUGIN. For UDF it was CREATE FUNCTION, that's why "already exists", I suppose. I just wonder if term "installed" is Ok for built-in plugins and those that were loaded by command line.
Whatever. Use something else. I just think that "exists" is kinda weird. Plugin exists (as, say, ha_tokudb.so) even if you didn't install it.
diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc index dc40870..21efeb0 100644 --- a/sql/sql_plugin.cc +++ b/sql/sql_plugin.cc @@ -1546,6 +1546,9 @@ int plugin_init(int *argc, char **argv, int flags) /* First we register builtin plugins */ + if (global_system_variables.log_warnings >= 9) + sql_print_information("Initializing mandatory plugins"); + for (builtins= mysql_mandatory_plugins; *builtins || mandatory; builtins++) { if (!*builtins)
Here you should've put "Initializing optional plugins". Actually, a better message would be "Initializing other built-in plugins" or " Initializing remaining built-in plugins". Sorry, I missed this. But do we need to distinguish between mandatory and optional built-ins? May be change "Initializing mandatory plugins" with "Initializing built-in plugins"?
That's fine too. I was only saying that not all built-in plugins are mandatory. Regards, Sergei