[Maria-discuss] Question regarding mariadb-dump/mysqldump and rocksdb
Hi MariaDB,
in Myrocks / Facebook MySQL there was a useful addition to mysqldump which makes queries issued by the dumper not add to the block cache of the rocksdb instance. It was added quite some time ago:
https://github.com/facebook/mysql-5.6/commit/2223479fea78a246884c5a09ef4d02f...
The corresponding server variable used is *rocksdb_skip_fill_cache*
Is this active in MariaDB's version of mysqldump as well? The server variable exists in MariaDB's MyRocks (checked for 10.6.12) but I have not found a reference in MariaDB's source code when searching for rocksdb_skip_fill_cache.
If it is not active it would be great if it could be added in a future version.
Best
Jonas
Sorry for delayed response Jonas,
It looks like quite a good addition. Please request a task https://jira.mariadb.org
As you've seen the code, you're welcome to make an addition (in connect_to_db).
On Tue, Apr 25, 2023 at 12:53 AM Jonas Krauss jkrauss82@gmail.com wrote:
Hi MariaDB,
in Myrocks / Facebook MySQL there was a useful addition to mysqldump which makes queries issued by the dumper not add to the block cache of the rocksdb instance. It was added quite some time ago:
https://github.com/facebook/mysql-5.6/commit/2223479fea78a246884c5a09ef4d02f...
The corresponding server variable used is rocksdb_skip_fill_cache
Is this active in MariaDB's version of mysqldump as well? The server variable exists in MariaDB's MyRocks (checked for 10.6.12) but I have not found a reference in MariaDB's source code when searching for rocksdb_skip_fill_cache.
If it is not active it would be great if it could be added in a future version.
Best
Jonas _______________________________________________ Mailing list: https://launchpad.net/~maria-discuss Post to : maria-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-discuss More help : https://help.launchpad.net/ListHelp
Hi Daniel,
thanks for the response, I will request a task and see if I can contribute with an implementation (but almost no C experience here).
Regards
Jonas
Am Mo., 15. Mai 2023 um 05:51 Uhr schrieb Daniel Black daniel@mariadb.org:
Sorry for delayed response Jonas,
It looks like quite a good addition. Please request a task https://jira.mariadb.org
As you've seen the code, you're welcome to make an addition (in connect_to_db).
On Tue, Apr 25, 2023 at 12:53 AM Jonas Krauss jkrauss82@gmail.com wrote:
Hi MariaDB,
in Myrocks / Facebook MySQL there was a useful addition to mysqldump
which makes queries issued by the dumper not add to the block cache of the rocksdb instance. It was added quite some time ago:
https://github.com/facebook/mysql-5.6/commit/2223479fea78a246884c5a09ef4d02f...
The corresponding server variable used is rocksdb_skip_fill_cache
Is this active in MariaDB's version of mysqldump as well? The server
variable exists in MariaDB's MyRocks (checked for 10.6.12) but I have not found a reference in MariaDB's source code when searching for rocksdb_skip_fill_cache.
If it is not active it would be great if it could be added in a future
version.
Best
Jonas _______________________________________________ Mailing list: https://launchpad.net/~maria-discuss Post to : maria-discuss@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-discuss More help : https://help.launchpad.net/ListHelp
participants (2)
-
Daniel Black -
Jonas Krauss