On 27/01/17 22:58, Michal Schorm wrote:
> Hello everybody,
>
> I made a (form my POV) bigger change to how MariaDB is packed, and I
> would be grateful for any feedback.

Thanks for continuing with this.

> I separated all the non-essential utilities to a standalone sub-package
> "server-utils".
> It should be installed automaticly with the "server" package as a weak
> dendency, so regular user should not spot any change.

Good. If every it becomes a non-dependency the following should be moved
to a dependent package:

/usr/bin/mysqldump  /usr/bin/mysqlbinlog /usr/bin/mysqlcheck
mysql_upgrade and associated man pages.

> Rawhide:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=17426872
> F25:
> https://bodhi.fedoraproject.org/updates/FEDORA-2017-0f44f2b8c8
> F24:
> https://bodhi.fedoraproject.org/updates/FEDORA-2017-801e01d1ed
>


questions/comments:

on the systemd settings:

ExecStopPost=/usr/libexec/mysql-wait-stop seems to just wait for pid, in
the case of Type=notify I thought this wasn't needed.

MDEV-10646, https://github.com/MariaDB/server/pull/297 should be an easy
fix.

https://github.com/MariaDB/server/blob/10.1/support-files/mariadb.service.in
has been updated a bit more to support added constraints and better
support for galera configurations.

errors:

/usr/libexec/mysql-scripts-common includes mysqld_safe as a section
however this isn't read by the systemd invocation of mysqld.

Running mysql (the client program) with these packages fails to find the
server socket.

strace of mysql sees and attempt to connect to a null string socket
socket(AF_UNIX, SOCK_STREAM, 0)         = 3
connect(3, {sa_family=AF_UNIX,
sun_path=@"\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"},
110) = -1 ECONNREFUSED (Connection refused)

There seems to be a lack of compile time to support the default of
/var/lib/mysql/mysql.sock

To be prudent, and to support other mysql client programs, including
socket=/var/lib/mysql/mysql.sock in a [client] section of a config file
is recommended.


recommendations:

/usr/share/mariadb/my-* - recommend dropping these. "huge" isn't really
a myisam configuration or an innodb with a 384M buffer pool. Other files
are equally as comicly harmful. Getting users to actually read rather
than these wild ass guesses as config files will save them much pain.


https://jira.mariadb.org/browse/MDEV-11869 might contains some insights
to systemd settings/packaging too.

 dnf list installed | grep -i mariadb
mariadb.x86_64                        3:10.1.21-1.fc24
@updates-testing
mariadb-common.x86_64                 3:10.1.21-1.fc24
@updates-testing
mariadb-config.x86_64                 3:10.1.21-1.fc24
@updates-testing
mariadb-errmsg.x86_64                 3:10.1.21-1.fc24
@updates-testing
mariadb-libs.x86_64                   3:10.1.21-1.fc24
@updates-testing
mariadb-server.x86_64                 3:10.1.21-1.fc24
@updates-testing
mariadb-server-utils.x86_64           3:10.1.21-1.fc24
@updates-testing