Greetings, Sergey! I've made yet another PR that covers comments inside */mysql-test/* : https://github.com/MariaDB/server/pull/3952 I've seen main.timezone test failing, but as far as I know I didn't touch it. There are ~200 more miscellaneous typos i've found, I'll create a separate PR for them soon. Once again, thank you for your time and attention. Best regards, Vasilii On 3/22/25 16:07, Vasilii Lakhin wrote:
Greetings, Sergey!
I've made two more PRs, covering
storage/: https://github.com/MariaDB/server/pull/3911 and other files: https://github.com/MariaDB/server/pull/3912
And with that i'm done with typos in C comments. Thank you for your time and attention.
Best regards, Vasilii
On 3/9/25 19:48, Vasilii Lakhin wrote:
Greetings, Sergey!
I've made the pull request, that covers sql/: https://github.com/MariaDB/server/pull/3882 It's approximately 70% of all typos I've found throughout the C comments, whole list contains ~1200 changes. Please let me know if you have any remarks.
Best regards, Vasilii
On 2/19/25 20:05, Sergey Vojtovich wrote:
Vasilii,
Well, there's no doubt it is going to be a big change, at the same time very easy to review. Looking at your patch, the only thing that I was doubtful about were non-english changes. You can start with fixing C/C++ comments, files under mysql-test should probably go separately, then non-english changes, then error messages/etc. That is 3-4 pull requests.
Regards, Sergey
On Wed, Feb 19, 2025 at 9:01 PM Vasilii Lakhin <qobood@gmail.com> wrote:
Greetings, Sergey!
Before I create a pull request, I want to ask how it would be convenient to interact (I estimate around 1000 words to be changed): 1. I'll make small patches (one alphabet letter at a time or 50 words at a time) and create PR for each take separately; 2. I'll make exact same patches, but with one PR; 3. One big patch, one PR?
I'm concerned about: 1. Checking a single patch will be too much of a hassle; 2. Approving each PR will be a hassle as well.
Or maybe there are better options that I don't know about. Thank you for response.
Best regards, Vasilii 19.02.2025 17:00, Sergey Vojtovich wrote:
Hi Vasilii,
Yes, please go ahead and create pull request against "main" branch. https://github.com/MariaDB/server/pulls
Regards, Sergey
On Sat, Feb 15, 2025 at 5:18 PM Lakhin Vasilii via discuss <discuss@lists.mariadb.org> wrote:
Forgot to attach the patch I mentioned. _______________________________________________ discuss mailing list -- discuss@lists.mariadb.org To unsubscribe send an email to discuss-leave@lists.mariadb.org