Hi Sergei,

I've fixed it, so the next release should have zstd again.
And we're adding tests to make sure this won't happen again.
Sorry for this.

No problem, I am glad this has been taken care of already. Will wait for the next release then.

Otto:

If you are a coder and want to spend development time yourself, then I

suggest you contribute to the PR review instead of spending time
building sources and maintaining repositories of your own.

As a matter of fact I am a coder, however I am not sure if I could be of help here (depends on the used languages and complexity of the code base). As we at Stockpulse are relying on MariaDB and have a good experience in general with the database I would be glad to contribute in one way or another. So I will have a look at the PR and see if I would be able to provide support, instead of trying to compile from source. Thanks for the advice.

Best

Jonas

Am Sa., 27. Juni 2020 um 19:16 Uhr schrieb Sergei Golubchik <serg@mariadb.org>:

Hi, Otto!

I did remake it, didn't know it was in your PR.
My fix was almost exactly the same as yours, down to missing underscores
in the error message. I've had one change inside Findzstd.cmake, but
that's the only difference.

In my defense, I've done it in 10.3, where the bug was introduced.

My commits are still in the stage branch, so if you'd like I can push
your commit instead.

On Jun 27, Otto Kekäläinen wrote:
> The zstd bugfix is the second cimmit in my PR has been open for 20 days. I
> hope Serg you cherry picked it instead of remaking it
>
> https://github.com/MariaDB/server/commit/b4a532b27bf1ab1fd1ff2a5db9638630010b57cc
>
> la 27. kesäk. 2020 klo 19.58 Sergei Golubchik <serg@mariadb.org> kirjoitti:
> >
> > It seems that zstd support has disappeared recently because of a bug
> > introduced as a merge mistake.
> >
> > I've fixed it, so the next release should have zstd again.
> > And we're adding tests to make sure this won't happen again.
> > Sorry for this.
> >
Regards,
Sergei
VP of MariaDB Server Engineering
and security@mariadb.org

_______________________________________________
Mailing list: https://launchpad.net/~maria-discuss
Post to : maria-discuss@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-discuss
More help : https://help.launchpad.net/ListHelp