- discuss - lists.mariadb.org

Help - Creating a loop to go through every row in a table, no errors, not working
by ram3n 01 Apr '24

01 Apr '24

Hi all, I've ran into a little roadblock while creating a WHILE loop within a procedure that's intended to go through every row within a table, *world.creature_template*. Query runs fine in my database, no warnings or errors, but it's not actually changing anything at all. Affected rows are always at 0. Link to the code is below, thanks in advance. https://srcb.in/YVuGJQU4o8 Some sample records: entrydifficulty_entry_1difficulty_entry_2difficulty_entry_3KillCredit1 KillCredit2modelid1modelid2modelid3modelid4namesubnameIconNamegossip_menu_id minlevelmaxlevelexpfactionnpcflagspeed_walkspeed_runscalerankdmgschool BaseAttackTimeRangeAttackTimeBaseVarianceRangeVarianceunit_classunit_flags unit_flags2dynamicflagsfamilytypetype_flagslootidpickpocketlootskinloot PetSpellDataIdVehicleIdmingoldmaxgoldAINameMovementTypeHoverHeight HealthModifierManaModifierArmorModifierDamageModifierExperienceModifier RacialLeadermovementIdRegenHealthmechanic_immune_mask spell_school_immune_maskflags_extraScriptNameVerifiedBuild 29 0 0 0 25499 0 25275 0 0 0 Kanrethad Master of Death 0 90 90 0 35 0 1 1.14286 1 0 0 2000 2000 1 1 1 0 2048 0 0 7 0 0 0 0 0 0 0 0 0 1 1250 1 1 1 1 0 0 1 0 0 0 12340 30 0 0 0 0 0 382 0 0 0 Forest Spider 0 5 6 0 22 0 1 0.85714 1 0 0 2000 2000 1 1 1 0 2048 0 3 1 1 30 0 0 5880 0 0 0 SmartAI 1 1 1 1 1 1 1 0 100 1 0 0 0 12340 31 0 0 0 0 0 145 0 0 0 Furbolg 0 1 2 0 35 0 1.2 1.14286 1 0 0 2000 2000 1 1 1 0 2048 0 0 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 0 0 1 0 0 0 12340 36 0 0 0 0 0 367 0 0 0 Harvest Golem 0 11 12 0 14 0 1 1.14286 1 0 0 2000 2000 1 1 1 0 2048 0 0 9 32768 36 0 0 0 0 13 21 1 1 1 1 1 1 1 0 0 1 16384 0 0 12340 38 0 0 0 0 0 5035 5036 0 0 Defias Thug 0 3 4 0 7 0 1 0.85714 1 0 0 2000 2000 1 1 1 0 2048 0 0 7 0 38 38 0 0 0 2 7 SmartAI 1 1 1 1 1 1 1 0 100 1 0 0 0 12340 40 0 0 0 0 0 373 0 0 0 Kobold Miner 0 6 7 0 26 0 1 0.85714 1 0 0 2000 2000 1 1 1 0 2048 0 0 7 0 40 40 0 0 0 5 12 SmartAI 1 1 1 1 1 1 1 0 100 1 0 0 0 12340 *generated 2024-03-31 22:08:23 by HeidiSQL 12.1.0.6537 <https://www.heidisql.com/>*

1 0

Spatial indexes, innodb, myisam and update lock cannot be acquired during a READ UNCOMMITTED transaction.
by Pascal Boulesteix 27 Mar '24

27 Mar '24

Hello everyone I am currently testing the migration of my web server to PHP 8.2.13 and mariadb 11.2.2. During my tests, I got stuck on a SELECT problem on tables using spatial indexes. During a complex page chaining several CREATE TABLEs on temporary tables with spatial indexes, a SELECT planted with the message "update lock cannot be acquired during a READ UNCOMMITTED transaction". After consulting Google, I first unblocked the situation by removing the spatial indexes on temporary tables but then the performance of intermediate queries collapsed. In the end, after doing a test package, I definitely found a solution: the default database engine is innodb. By forcing the myisam engine on the temporary tables the page executes in a few seconds! Questions: - what to think of this use case of spatial indexes with innodb vs myisa? - Is this a bug? Below are the DMLs for queries with myisam explicitly indicated. With innodb, the last query in the list crashes, either timeout if I execute via php, or "update lock cannot be acquired during a READ UNCOMMITTED transaction" if I execute the query via phpmyadmin 1 CREATE TABLE TEMPTABLE_localites_du_site(Localite_unik_commune int, Localite_dept varchar(15), Localite_unik int, GPS_unik int, Type_Localite varchar(1), Localite_p_coordonnees_spacial point not null) ENGINE = myisam ; 0 0 2 ALTER TABLE TEMPTABLE_localites_du_site ADD SPATIAL INDEX IDX_temptable_localites_du_site_Localite_p_coordonnees_spacial(Localite_p_coordonnees_spacial); 0 0 1 CREATE TABLE WKWNat_2A2B50F4_415A_443F_A959_38AB2F0EC1C6 (Localite_unik_commune int, Localite_dept varchar(15), Localite_unik int, GPS_unik int, Type_Localite varchar(1), Localite_p_coordonnees_spacial point, Maille_unik int, Maille_unik_site int, Maille_maille varchar(80), Maille_taille int, Maille_g_coordonnees_spacial geometry NOT NULL, Maille_couleur_bordure int, Maille_couleur_aire int, Maille_transparence_aire int, Maille_Exclusion bit NOT NULL, Longitude_Centre double(10,6), Latitude_Centre double(10,6), in_use_by_leudit bit NOT NULL, myTaille varchar(3)) ENGINE = myisam; 0 0 5 insert INTO TEMPTABLE_localites_du_site (SELECT DISTINCT wnat_lieuxdits.unik_commune, wnat_communes.Dept, wnat_lieuxdits.unik AS unik_lieudit, NULL AS unik_gps, 'L' AS Type_Localite, wnat_lieuxdits.p_coordonnees_spacial FROM wnat_lieuxdits INNER JOIN wnat_inventaires ON wnat_inventaires.unik_lieudit = wnat_lieuxdits.unik INNER JOIN wnat_communes ON wnat_communes.unik = wnat_lieuxdits.unik_commune WHERE wnat_inventaires.unik_organisme=10 AND ST_CONTAINS(ST_PolygonFromText('POLYGON((41.36475929466526 8.54315203804477,43.0275854970405 8.54315203804477,43.0275854970405 9.555702267296203,41.36475929466526 9.555702267296203,41.36475929466526 8.54315203804477))'),wnat_lieuxdits.p_coordonnees_spacial) ) 0 788 6 insert INTO TEMPTABLE_localites_du_site (SELECT DISTINCT wnat_lieuxdits.unik_commune, wnat_communes.Dept, wnat_lieuxdits.unik AS unik_lieudit, wnat_gps.unik AS unik_gps, 'G' AS Type_Localite, wnat_gps.p_coordonnees_spacial FROM wnat_lieuxdits INNER JOIN wnat_gps ON wnat_lieuxdits.unik = wnat_gps.unik_lieudit INNER JOIN wnat_inventaires ON wnat_gps.unik = wnat_inventaires.unik_gps INNER JOIN wnat_communes ON wnat_communes.unik = wnat_lieuxdits.unik_commune WHERE wnat_inventaires.unik_organisme=10 AND ST_CONTAINS(ST_PolygonFromText('POLYGON((41.36475929466526 8.54315203804477,43.0275854970405 8.54315203804477,43.0275854970405 9.555702267296203,41.36475929466526 9.555702267296203,41.36475929466526 8.54315203804477))'),wnat_gps.p_coordonnees_spacial) ) 0 29566 7 DELETE TEMPTABLE_localites_du_site FROM TEMPTABLE_localites_du_site INNER JOIN wnat_lieuxdits ON ( TEMPTABLE_localites_du_site.Localite_unik = wnat_lieuxdits.unik) INNER JOIN wnat_communes ON (wnat_lieuxdits.unik_commune = wnat_communes.unik) where wnat_communes.unik_organisme<>10 0 0 765 CREATE TABLE TEMPTABLE_W1 ENGINE = myisam AS SELECT MAX(wnat_geometries_mailles.taille) AS max_taille FROM TEMPTABLE_localites_du_site INNER JOIN wnat_geometries_mailles ON ST_CONTAINS(wnat_geometries_mailles.g_coordonnees_spacial, TEMPTABLE_localites_du_site.Localite_p_coordonnees_spacial) WHERE wnat_geometries_mailles.unik_geometrie_objet IN (121332,121333,121334,121335,121419,121385,121376,121383,121449,121450,121345,121373,121370,121371,121317,121379,121355,121362,121363,121367,121372,121346,121347,121348,121349,121365,121366,121378,121442,121443,121444,121448,121411,121404,121325,121406,121315,121392,121393,121394,121395,121396,121391,121343,121344,121407,121388,121389,121412,121413,121414,121415,121420,121421,121422,121423,121424,121322,121318,121319,121320,121321,121369,121360,121361,121426,121427,121428,121429,121430,121431,121432,121327,121356,121357,121405,121316,121408,121409,121425,121375,121351,121350,121323,121384,121390,121364,121324,121416,121417,121418,121368,121386,121387,121352,121447,121440,121441,121433,121434,121435,121328,121329,121330,121331,121446,121374,121451,121397,121377,121445,121382,121336,121337,121338,121339,121340,121341,121342,121436,121437,121438,121353,121354,121380,121381,121439,121326,121398,121399,121400,121401,121402,121403,121410,121358,121359,-1) AND wnat_geometries_mailles.Exclusion = FALSE; 0 1 query_Recordset1 insert INTO WKWNat_2A2B50F4_415A_443F_A959_38AB2F0EC1C6 (SELECT TEMPTABLE_localites_du_site.Localite_unik_commune, TEMPTABLE_localites_du_site.Localite_dept, TEMPTABLE_localites_du_site.Localite_unik, TEMPTABLE_localites_du_site.GPS_unik, TEMPTABLE_localites_du_site.Type_Localite, TEMPTABLE_localites_du_site.Localite_p_coordonnees_spacial, wnat_geometries_mailles.unik, wnat_geometries_mailles.unik_geometrie_objet, wnat_geometries_mailles.maille, wnat_geometries_mailles.taille, wnat_geometries_mailles.g_coordonnees_spacial, wnat_geometries_mailles.couleur_bordure, wnat_geometries_mailles.couleur_aire, wnat_geometries_mailles.transparence_aire, wnat_geometries_mailles.Exclusion, wnat_geometries_mailles.longitude_centre, wnat_geometries_mailles.latitude_centre, 1, MAX_TAILLE.max_taille AS myTaille FROM TEMPTABLE_localites_du_site INNER JOIN wnat_geometries_mailles ON ST_CONTAINS(wnat_geometries_mailles.g_coordonnees_spacial, TEMPTABLE_localites_du_site.Localite_p_coordonnees_spacial) INNER JOIN TEMPTABLE_W1 as MAX_TAILLE ON wnat_geometries_mailles.taille = MAX_TAILLE.max_taille WHERE wnat_geometries_mailles.unik_geometrie_objet IN (121332,121333,121334,121335,121419,121385,121376,121383,121449,121450,121345,121373,121370,121371,121317,121379,121355,121362,121363,121367,121372,121346,121347,121348,121349,121365,121366,121378,121442,121443,121444,121448,121411,121404,121325,121406,121315,121392,121393,121394,121395,121396,121391,121343,121344,121407,121388,121389,121412,121413,121414,121415,121420,121421,121422,121423,121424,121322,121318,121319,121320,121321,121369,121360,121361,121426,121427,121428,121429,121430,121431,121432,121327,121356,121357,121405,121316,121408,121409,121425,121375,121351,121350,121323,121384,121390,121364,121324,121416,121417,121418,121368,121386,121387,121352,121447,121440,121441,121433,121434,121435,121328,121329,121330,121331,121446,121374,121451,121397,121377,121445,121382,121336,121337,121338,121339,121340,121341,121342,121436,121437,121438,121353,121354,121380,121381,121439,121326,121398,121399,121400,121401,121402,121403,121410,121358,121359,-1) AND wnat_geometries_mailles.Exclusion = FALSE and in_use_by_lieudit<>0); 8 insert INTO WKWNat_2A2B50F4_415A_443F_A959_38AB2F0EC1C6 (SELECT TEMPTABLE_localites_du_site.Localite_unik_commune, TEMPTABLE_localites_du_site.Localite_dept, TEMPTABLE_localites_du_site.Localite_unik, TEMPTABLE_localites_du_site.GPS_unik, TEMPTABLE_localites_du_site.Type_Localite, TEMPTABLE_localites_du_site.Localite_p_coordonnees_spacial, wnat_geometries_mailles.unik, wnat_geometries_mailles.unik_geometrie_objet, wnat_geometries_mailles.maille, wnat_geometries_mailles.taille, wnat_geometries_mailles.g_coordonnees_spacial, wnat_geometries_mailles.couleur_bordure, wnat_geometries_mailles.couleur_aire, wnat_geometries_mailles.transparence_aire, wnat_geometries_mailles.Exclusion, wnat_geometries_mailles.longitude_centre, wnat_geometries_mailles.latitude_centre, 1, MAX_TAILLE.max_taille AS myTaille FROM TEMPTABLE_localites_du_site INNER JOIN wnat_geometries_mailles ON ST_CONTAINS(wnat_geometries_mailles.g_coordonnees_spacial, TEMPTABLE_localites_du_site.Localite_p_coordonnees_spacial) INNER JOIN TEMPTABLE_W1 as MAX_TAILLE ON wnat_geometries_mailles.taille = MAX_TAILLE.max_taille WHERE wnat_geometries_mailles.unik_geometrie_objet IN (121332,121333,121334,121335,121419,121385,121376,121383,121449,121450,121345,121373,121370,121371,121317,121379,121355,121362,121363,121367,121372,121346,121347,121348,121349,121365,121366,121378,121442,121443,121444,121448,121411,121404,121325,121406,121315,121392,121393,121394,121395,121396,121391,121343,121344,121407,121388,121389,121412,121413,121414,121415,121420,121421,121422,121423,121424,121322,121318,121319,121320,121321,121369,121360,121361,121426,121427,121428,121429,121430,121431,121432,121327,121356,121357,121405,121316,121408,121409,121425,121375,121351,121350,121323,121384,121390,121364,121324,121416,121417,121418,121368,121386,121387,121352,121447,121440,121441,121433,121434,121435,121328,121329,121330,121331,121446,121374,121451,121397,121377,121445,121382,121336,121337,121338,121339,121340,121341,121342,121436,121437,121438,121353,121354,121380,121381,121439,121326,121398,121399,121400,121401,121402,121403,121410,121358,121359,-1) AND wnat_geometries_mailles.Exclusion = FALSE and in_use_by_lieudit<>0); 0 17672

1 0

Advice concerning inconsistent query results
by Jef Van Loon 24 Mar '24

24 Mar '24

Hello, I am looking for advice concering inconsistent query results. Problem: We are observing queries that return inconsistent query results. The query in question selects records within a period of time (e.g., month) based on a datetime column. The result set is missing random records within the queried time period. It appears that the inconsistent result is produced when the query uses an index containing the datetime column. When the index is not used, the result seems to contain all records. Dropping and recreating the index caused the result to be complete again. However, this has NOT solved the problem permanently as the wrong behaviour has reappeared afterwards. On second appearance, we have used OPTIMIZE table on the table in question which has again resolved the problem, we will have to wait to see whether the problem occurs again. CHECK TABLE returned no erros for the affected table. The problem does not seem to be limited to one installation, we are seing it on different MariaDB installations. Questions: - Has anybody seen such behaviour in the past? - How can we diagnose the problem? Environment: - MariaDB Version: MariaDB 10.5.13 - MariaDB Storage engine: InnoDB - MariaDB Collation: utf8mb4_unicode_ci - OS: Windows Server Kind regards, Jef

4 7

Possible Security Bug
by Gordan Bobic 24 Mar '24

24 Mar '24

Hi, What is an appropriate forum for discussing what seems to be a security bug that I ran into?

3 3

Re: Setting up a jira self hosted instance
by Daniel Black 20 Mar '24

20 Mar '24

Query obviously from connector. Works in 11.3.3 MariaDB [test]> SELECT @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@collation_connection AS collation_connection, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_write_timeout AS net_write_timeout, @@performance_schema AS performance_schema, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@transaction_isolation AS transaction_isolation, @@wait_timeout AS wait_timeout\G *************************** 1. row *************************** auto_increment_increment: 1 character_set_client: utf8mb3 character_set_connection: utf8mb3 character_set_results: utf8mb3 character_set_server: latin1 collation_server: latin1_swedish_ci collation_connection: utf8mb3_general_ci init_connect: interactive_timeout: 28800 license: GPL lower_case_table_names: 0 max_allowed_packet: 16777216 net_write_timeout: 60 performance_schema: 0 sql_mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION system_time_zone: AEDT time_zone: SYSTEM transaction_isolation: REPEATABLE-READ wait_timeout: 28800 1 row in set (0.001 sec) MariaDB [test]> select version(); +----------------+ | version() | +----------------+ | 11.3.3-MariaDB | +----------------+ 1 row in set (0.000 sec) Obviously fails in earlier versions: MariaDB [test]> SELECT @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@collation_connection AS collation_connection, -> @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_write_timeout AS net_write_timeout, @@performance_schema AS performance_schema, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@transaction_isolation AS transaction_isolation, @@wait_timeout AS wait_timeout\G ERROR 1193 (HY000): Unknown system variable 'transaction_isolation' MariaDB [test]> select version(); +-----------------+ | version() | +-----------------+ | 10.11.8-MariaDB | +-----------------+ 1 row in set (0.000 sec) Are you sure you have the right version of MariaDB that you described? Otherwise upgrade/use MariaDB Connector/J. On Thu, 21 Mar 2024 at 04:45, <juanhernandez98(a)gmail.com> wrote: > > Just as a FYI, I enabled the MariaDB general logs: > > And I'm getting this when the jira instance tries and connect to my mriadb server: > > 240319 14:28:23 239 Connect jira@localhost on jira using TCP/IP > 239 Query SET SESSION default_storage_engine=InnoDB > 239 Query /* mysql-connector-j-8.3.0 (Revision: 805f872a57875f311cb82487efcfb070411a3fa0) */SELECT @@session.auto_increment_increment AS auto_increment_increment, @@character_set_client AS character_set_client, @@character_set_connection AS character_set_connection, @@character_set_results AS character_set_results, @@character_set_server AS character_set_server, @@collation_server AS collation_server, @@collation_connection AS collation_connection, @@init_connect AS init_connect, @@interactive_timeout AS interactive_timeout, @@license AS license, @@lower_case_table_names AS lower_case_table_names, @@max_allowed_packet AS max_allowed_packet, @@net_write_timeout AS net_write_timeout, @@performance_schema AS performance_schema, @@sql_mode AS sql_mode, @@system_time_zone AS system_time_zone, @@time_zone AS time_zone, @@transaction_isolation AS transaction_isolation, @@wait_timeout AS wait_timeout > > > -----Original Message----- > From: Daniel Black via discuss <discuss(a)lists.mariadb.org> > Sent: Tuesday, March 19, 2024 9:57 PM > To: discuss(a)lists.mariadb.org > Subject: [MariaDB discuss] Re: Setting up a jira self hosted instance > > On Wed, 20 Mar 2024 at 07:20, Juan Hernandez via discuss <discuss(a)lists.mariadb.org> wrote: > > > > Hi, > > > > So I’ve been running MariaDB 11.3 for a while. I have various applications working great with this server. > > > > I want to setup a Jira 9.14 self hosted instance on one of my servers. I see mariadb.com uses Jira. > > > > So I put the mysql java connector v8.3.0, and the mariadb java connector v3.3.3 installed in my /opt/Atlassian/jira/lib directory. > > > > I tried connecting jira via the setup web interface to my maria db, using the mysql 8.0 driver, and I get the error that I’m not running the right version. > > > > Is that from the driver or from JIRA? > > > I then added under [mysqld] in my.cnf, version = “8.0.25-0” and now get the below error. > > > Error connecting to database > > > > Unknown system variable 'transaction_isolation' > > https://jira.mariadb.org/browse/MDEV-21921 - added this to 11.1, so you should be right in 11.3. Its not 10.11.3 right? > > Can JIRA use the MariaDB Java Connector v3.3.3? > > A last resort is to specify the version=5.7.44 (any 5.7) and/or use a > 5.7 compatible mysql java connector. > > > > I am now getting this error when testing the connection in jira: > > > > I don’t want to setup a postgresql instance or a mysql 8 instance, can I get this to work? Any help would be greatly appreciated. > > Us too. We're still battling against JIRA supported databases a little after all these years. > _______________________________________________ > discuss mailing list -- discuss(a)lists.mariadb.org To unsubscribe send an email to discuss-leave(a)lists.mariadb.org >

1 0

Setting up a jira self hosted instance
by juanhernandez98＠gmail.com 20 Mar '24

20 Mar '24

Hi, So I've been running MariaDB 11.3 for a while. I have various applications working great with this server. I want to setup a Jira 9.14 self hosted instance on one of my servers. I see mariadb.com uses Jira. So I put the mysql java connector v8.3.0, and the mariadb java connector v3.3.3 installed in my /opt/Atlassian/jira/lib directory. I tried connecting jira via the setup web interface to my maria db, using the mysql 8.0 driver, and I get the error that I'm not running the right version. I then added under [mysqld] in my.cnf, version = "8.0.25-0" and now get the below error. Error connecting to database Unknown system variable 'transaction_isolation' I am now getting this error when testing the connection in jira: I don't want to setup a postgresql instance or a mysql 8 instance, can I get this to work? Any help would be greatly appreciated. Best Juan

2 1

Trigger Fails
by steffan＠hldns.com 15 Mar '24

15 Mar '24

I just converted to MariaDB from MySQL where this trigger worked fine. DELIMITER ;; CREATE TRIGGER `email_uuid_before_insert` BEFORE INSERT ON `email` FOR EACH ROW BEGIN IF new.id_email IS NULL THEN SET new.id_email = uuid(); END IF; END;; DELIMITER ;; In MariaDB, it creates with no errors but when adding a row, I get an error 1062 : Duplicate entry '' for key 'PRIMARY' It’s caused because the last row that inserted wasn’t populated with that UUID – meaning the trigger failed. What would cause this to fail? Thank you, Steffan Cline steffan(a)hldns.com<mailto:steffan@hldns.com> 602-793-0014

2 2

Support for MariaDB Community Repo after EL7 EOL
by james.manley＠jadu.co.uk 14 Mar '24

14 Mar '24

Hi, We currently use MariaDB 10.5 from the MariaDB Community Repo on EL7. EL7 is end of life at the end of June 2024. Will MariaDB 10.5 continue to receive support and security updates until its end of life, or will support and updates stop on EL7 once the OS reaches end of life? Thanks!

2 1

MariaDB's Percona Tookit Fork Source Code Repository?
by Gordan Bobic 13 Mar '24

13 Mar '24

Hi, I noticed references to these tools: https://mariadb.com/kb/en/mariadb-tools/ but the github links are all 404. Where can all of the sources for these be downloaded from?

3 4

next and previous words
by ChipsRunner 24 Feb '24

24 Feb '24

Hi I've noticed that between debian 10 and 11 (mariadb-client-core-10.3 and mariadb-client-core-10.5) the client console tool (CLI) treats words in a different way: alt+f and alt+b will skip the dot on the new version. Example if I have something like 'test.domain.com' using alt+f on the old version would treat 'test', 'domain' and 'com' as three separate words while the new version would skip at the end of '.com' Is there a way to restore the old behaviour ? Thank you, PM

2 2