[Maria-developers] Please review MDEV-11298 also fixing GIS bugs MDEV-9405 and MDEV-9425
Hello Alexey, Please review a patch for: MDEV-11302 Add class Type_ext_attributes and Type_handler::join_type_ext_attributes() A detailed description can be found in the task ticket: https://jira.mariadb.org/browse/MDEV-11302 This patch also fixes the problems reported in: MDEV-9405 Hybrid functions, SP do not preserve geometry type MDEV-9425 Hybrid functions and UNION do not preserve spatial REF_SYSTEM_ID Some calls for geometry_type() and/or srid() were forgotten in the old code. The new code replaces calls for geometry_type() and srid() to a generic type_ext_attributes() and makes maintaining/adding of similar data type specific attributes easier. The new class Type_ext_attributes will be used in a few field creation methods in Type_handler later. Thanks!
Привет, Леха! Че-то я запутался с номерами. Прошу прощения. Вместо: Please review MDEV-11298 also fixing GIS bugs MDEV-9405 and MDEV-9425 в этом письме должно было быть: Please review MDEV-11302 also fixing GIS bugs MDEV-9405 and MDEV-9425 И имя патча было неверное. А настоящий MDEV-11298 я оправлял другим письмом. То есть всего осталось два патча из тех, что я отправлял тебе на ревью: MDEV-11298 Split Item_func_hex::val_str_ascii() into virtual methods in Type_handler MDEV-11302 Add class Type_ext_attributes and Type_handler::join_type_ext_attributes() On 11/17/2016 05:57 PM, Alexander Barkov wrote:
Hello Alexey,
Please review a patch for:
MDEV-11302 Add class Type_ext_attributes and Type_handler::join_type_ext_attributes()
A detailed description can be found in the task ticket: https://jira.mariadb.org/browse/MDEV-11302
This patch also fixes the problems reported in:
MDEV-9405 Hybrid functions, SP do not preserve geometry type MDEV-9425 Hybrid functions and UNION do not preserve spatial REF_SYSTEM_ID
Some calls for geometry_type() and/or srid() were forgotten in the old code.
The new code replaces calls for geometry_type() and srid() to a generic type_ext_attributes() and makes maintaining/adding of similar data type specific attributes easier.
The new class Type_ext_attributes will be used in a few field creation methods in Type_handler later.
Thanks!
participants (1)
-
Alexander Barkov