[Maria-developers] 5.3 compilation warnings
Hi Timour, When one compiles 5.3, it produces the following warnings which I believe fall into your turf. Could you please fix them: item_subselect.cc: In member function ‘bool subselect_rowid_merge_engine::init(MY_BITMAP*, MY_BITMAP*)’: item_subselect.cc:4826: warning: ignoring return value of ‘int handler::ha_rnd_init(bool)’, declared with attribute warn_unused_result item_subselect.cc: In member function ‘virtual bool subselect_rowid_merge_engine::partial_match()’: item_subselect.cc:5007: warning: ignoring return value of ‘int handler::ha_rnd_init(bool)’, declared with attribute warn_unused_result item_subselect.cc: In member function ‘virtual bool subselect_table_scan_engine::partial_match()’: item_subselect.cc:5174: warning: ignoring return value of ‘int handler::ha_rnd_init(bool)’, declared with attribute warn_unused_result sql_class.cc: In member function ‘virtual bool select_materialize_with_stats::create_result_table(THD*, List<Item>*, bool, ulonglong, const char*, bool)’: sql_class.cc:3020: warning: the address of ‘int stat(const char*, stat*)’ will always evaluate as ‘true’ BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog
Hi, Sergey!
sql_class.cc: In member function ???virtual bool select_materialize_with_stats::create_result_table(THD*, List<Item>*, bool, ulonglong, const char*, bool)???: sql_class.cc:3020: warning: the address of ???int stat(const char*, stat*)??? will always evaluate as ???true???
I've fixed that already Regards, Sergei
Sergey, I noticed these while building my recent bug fixes, but I wanted to fix them in a separate patch. Patch will follow very soon. Timour
Hi Timour,
When one compiles 5.3, it produces the following warnings which I believe fall into your turf. Could you please fix them:
item_subselect.cc: In member function ‘bool subselect_rowid_merge_engine::init(MY_BITMAP*, MY_BITMAP*)’: item_subselect.cc:4826: warning: ignoring return value of ‘int handler::ha_rnd_init(bool)’, declared with attribute warn_unused_result item_subselect.cc: In member function ‘virtual bool subselect_rowid_merge_engine::partial_match()’: item_subselect.cc:5007: warning: ignoring return value of ‘int handler::ha_rnd_init(bool)’, declared with attribute warn_unused_result item_subselect.cc: In member function ‘virtual bool subselect_table_scan_engine::partial_match()’: item_subselect.cc:5174: warning: ignoring return value of ‘int handler::ha_rnd_init(bool)’, declared with attribute warn_unused_result
sql_class.cc: In member function ‘virtual bool select_materialize_with_stats::create_result_table(THD*, List<Item>*, bool, ulonglong, const char*, bool)’: sql_class.cc:3020: warning: the address of ‘int stat(const char*, stat*)’ will always evaluate as ‘true’
BR Sergey
participants (3)
-
Sergei Golubchik
-
Sergey Petrunya
-
Timour Katchaounov