Re: [Maria-developers] [Commits] Rev 3482: post review changes - interface (part 3)
![](https://secure.gravatar.com/avatar/3c2329333dd5898f2e72818af773243d.jpg?s=120&d=mm&r=g)
Hi, Sanja! On Dec 21, sanja@askmonty.org wrote:
At file:///home/bell/maria/bzr/work-maria-10.0-cassandra/
------------------------------------------------------------ revno: 3482 revision-id: sanja@askmonty.org-20121220233538-b171yhb9isogvd5h parent: sanja@askmonty.org-20121220204008-fox73otsp1lviqda committer: sanja@askmonty.org branch nick: work-maria-10.0-cassandra timestamp: Fri 2012-12-21 01:35:38 +0200 message: post review changes - interface (part 3)
=== modified file 'include/ma_dyncol.h' --- a/include/ma_dyncol.h 2012-12-20 20:40:08 +0000 +++ b/include/ma_dyncol.h 2012-12-20 23:35:38 +0000 @@ -100,6 +100,8 @@ struct st_dynamic_column_value
typedef struct st_dynamic_column_value DYNAMIC_COLUMN_VALUE;
+/* old functions (depricated) */ +#ifdef MADYNCOL_DEPRICATED
"deprEcated"
enum enum_dyncol_func_result dynamic_column_create(DYNAMIC_COLUMN *str, uint column_nr, DYNAMIC_COLUMN_VALUE *value); @@ -133,75 +120,105 @@ dynamic_column_update_many(DYNAMIC_COLUM uint *column_numbers, DYNAMIC_COLUMN_VALUE *values); enum enum_dyncol_func_result -dynamic_column_update_many_fmt(DYNAMIC_COLUMN *str, - uint add_column_count, - void *column_keys, - DYNAMIC_COLUMN_VALUE *values, - my_bool string_keys); - -enum enum_dyncol_func_result dynamic_column_delete(DYNAMIC_COLUMN *org, uint column_nr);
enum enum_dyncol_func_result dynamic_column_exists(DYNAMIC_COLUMN *org, uint column_nr); + enum enum_dyncol_func_result -dynamic_column_exists_named(DYNAMIC_COLUMN *str, LEX_STRING *name); +dynamic_column_list(DYNAMIC_COLUMN *org, DYNAMIC_ARRAY *array_of_uint); + enum enum_dyncol_func_result -dynamic_column_exists_fmt(DYNAMIC_COLUMN *str, void *key, my_bool string_keys); +dynamic_column_get(DYNAMIC_COLUMN *org, uint column_nr, + DYNAMIC_COLUMN_VALUE *store_it_here); +#endif
-/* List of not NULL columns */ +/* new functions */ enum enum_dyncol_func_result -dynamic_column_list(DYNAMIC_COLUMN *org, DYNAMIC_ARRAY *array_of_uint); +madyncol_create_many(DYNAMIC_COLUMN *str,
"madyncol" looks silly :) let's agree on one namespace prefix and use it everywhere. either it's ma_ like in ma_open ma_dyncol_create_many ma_alloc or it's maria_ like in maria_open maria_dyncol_create_many maria_alloc
+ uint column_count, + uint *column_numbers, + DYNAMIC_COLUMN_VALUE *values, + my_bool new_string);
Regards, Sergei
![](https://secure.gravatar.com/avatar/fb07215019ed6b599f8663bee80727eb.jpg?s=120&d=mm&r=g)
Hi,
"madyncol" looks silly :) let's agree on one namespace prefix and use it everywhere. either it's ma_ like in
ma_open ma_dyncol_create_many ma_alloc
or it's maria_ like in
maria_open maria_dyncol_create_many maria_alloc
I think we should use the vendor prefix "mariadb" instead of "maria" (Maria was the previous name of the aria storage engine, but dynamic columns work with all storage engines). This should be consistent for all api functions. mariadb_dyncol_[function_name] implies, that we are using a dynamic column function for MariaDB. For internal (non api functions) ma_ prefix is ok. /Georg
participants (2)
-
Georg Richter
-
Sergei Golubchik