Re: 175adef14ef: MDEV-32537 due to Linux, restrict thread name 15 characters, also in PS.
Hi, Vladislav, On Jun 08, Vladislav Vaintroub wrote:
revision-id: 175adef14ef (mariadb-11.0.1-288-g175adef14ef) parent(s): 4ffb583d72f author: Vladislav Vaintroub committer: Vladislav Vaintroub timestamp: 2024-01-25 09:57:52 +0100 message:
MDEV-32537 due to Linux, restrict thread name 15 characters, also in PS.
Rename some threads to workaround this restrictions, e.g "rpl_parallel_thread"->"rpl_parallel", "slave_background" -> "slave_bg" etc.
I know I suggested that, but I'm getting a second thought now, sorry. This would break compatibility with performance schema tools, whatever they might be. I don't know if there are any, though, so may be it's not a concern. Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org
Neither am I aware of any tool, that would use hardcoded perfschema thread names for anything. If there was something worthy, we would be aware by now, 15years after perfschema debut. So, how do we proceed with this? We can leave the check against perfschema names as it currently stands, wait and see, and in case it breaks something, fix it until next LTS is out. Or I can remove the perfschema check. I'm OK with both. On Sat, Jun 8, 2024 at 9:24 PM Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Vladislav,
On Jun 08, Vladislav Vaintroub wrote:
revision-id: 175adef14ef (mariadb-11.0.1-288-g175adef14ef) parent(s): 4ffb583d72f author: Vladislav Vaintroub committer: Vladislav Vaintroub timestamp: 2024-01-25 09:57:52 +0100 message:
MDEV-32537 due to Linux, restrict thread name 15 characters, also in PS.
Rename some threads to workaround this restrictions, e.g "rpl_parallel_thread"->"rpl_parallel", "slave_background" -> "slave_bg" etc.
I know I suggested that, but I'm getting a second thought now, sorry.
This would break compatibility with performance schema tools, whatever they might be. I don't know if there are any, though, so may be it's not a concern.
Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org
Hi, Vladislav, Ok, most of the names you've changes are MariaDB specific anyway. Let's change and see. Note they some of the names are mentioned in comments in sys schema, please update it too. Otherwise ok to put in testing Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org On Jun 09, Vladislav Vaintroub wrote:
Neither am I aware of any tool, that would use hardcoded perfschema thread names for anything. If there was something worthy, we would be aware by now, 15years after perfschema debut. So, how do we proceed with this? We can leave the check against perfschema names as it currently stands, wait and see, and in case it breaks something, fix it until next LTS is out. Or I can remove the perfschema check. I'm OK with both.
On Sat, Jun 8, 2024 at 9:24 PM Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Vladislav,
On Jun 08, Vladislav Vaintroub wrote:
revision-id: 175adef14ef (mariadb-11.0.1-288-g175adef14ef) parent(s): 4ffb583d72f author: Vladislav Vaintroub committer: Vladislav Vaintroub timestamp: 2024-01-25 09:57:52 +0100 message:
MDEV-32537 due to Linux, restrict thread name 15 characters, also in PS.
Rename some threads to workaround this restrictions, e.g "rpl_parallel_thread"->"rpl_parallel", "slave_background" -> "slave_bg" etc.
I know I suggested that, but I'm getting a second thought now, sorry.
This would break compatibility with performance schema tools, whatever they might be. I don't know if there are any, though, so may be it's not a concern.
Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org
participants (2)
-
Sergei Golubchik -
Vladislav Vaintroub