[Maria-developers] Buildbot failures: Microsecond-related changes break innodb_plugin but not xtradb
Hi! All of the recent 5.3 builds in buildbot have two failures: innodb_plugin.innodb_bug54044 'innodb_plugin' innodb_plugin.innodb_information_schema 'innodb_plugin' The failure happens only with innodb_plugin. XtraDB is fine. I've investigated the first problem. Its cause is in storage/xtradb/handler/ha_innodb.cc:get_innobase_type_from_mysql_type(): - On 2010-08-04, Kristian did a merge from XtraDB in Percona-Server-5.1.47-11 and among everything else pulled in the code that will produce error when the function's argument is Field_null. This seems to be the bugfix for BUG#54044 - On 2011-03-29, Sergei was making fix for lp:743017 in 5.1-micro, switched the function from analyzing field->type() to analyzing field->key_type() and in the process removed the part of code that Kristian has added. For some reason, he did that storage/innodb_plugin and storage/innobase but not to storage/xtradb. - On May, 28th Monty has merged in Sergei's change into 5.3-main and we started to get the failure. I see two problems here: P1: (the apparent one) Sergei's new code doesn't produce error when passed a Field_null object. P2: (less apparent one) Why do we have Microsecond changes in innodb_plugin but not in xtradb? Could there be more fixes missing in a similar way? Sergei, could you please take a look? BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog
On Sat, Jun 04, 2011 at 01:19:42PM +0400, Sergey Petrunya wrote:
Hi!
All of the recent 5.3 builds in buildbot have two failures:
innodb_plugin.innodb_bug54044 'innodb_plugin' <skip>
The problematic changesets are: revno: 3009 [merge] revision-id: monty@askmonty.org-20110528030022-b9c4gk1db5lw9fmo parent: wlad@montyprogram.com-20110527170535-wb0dbkccp4imlmvj parent: monty@askmonty.org-20110528025816-olzav9xlvgnmq4ub committer: Michael Widenius <monty@askmonty.org> branch nick: maria-5.3 timestamp: Sat 2011-05-28 06:00:22 +0300 message: Automatic merge revno: 2502.1147.35 revision-id: sergii@pisem.net-20110329124848-r3n2hc7sntw89hpd parent: sergii@pisem.net-20110328170156-tym8c702vt09owe9 fixes bug(s): https://launchpad.net/bugs/743017 committer: Sergei Golubchik <sergii@pisem.net> branch nick: microseconds-5.1.54 timestamp: Tue 2011-03-29 14:48:48 +0200 message: lp:743017 Diverging results with TIME(3) and ranges depending on the execution plan in 5.1-micro rewrite get_innobase_type_from_mysql_type() to use types as reported by the Field objects, instead of relying on ad-hoc assumptions. BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog
On 06/04/2011 02:19 AM, Sergey Petrunya wrote:
Hi!
All of the recent 5.3 builds in buildbot have two failures:
innodb_plugin.innodb_bug54044 'innodb_plugin' innodb_plugin.innodb_information_schema 'innodb_plugin'
The failure happens only with innodb_plugin. XtraDB is fine.
I've investigated the first problem. Its cause is in storage/xtradb/handler/ha_innodb.cc:get_innobase_type_from_mysql_type():
- On 2010-08-04, Kristian did a merge from XtraDB in Percona-Server-5.1.47-11 and among everything else pulled in the code that will produce error when the function's argument is Field_null. This seems to be the bugfix for BUG#54044
- On 2011-03-29, Sergei was making fix for lp:743017 in 5.1-micro, switched the function from analyzing field->type() to analyzing field->key_type() and in the process removed the part of code that Kristian has added. For some reason, he did that storage/innodb_plugin and storage/innobase but not to storage/xtradb.
- On May, 28th Monty has merged in Sergei's change into 5.3-main and we started to get the failure.
I see two problems here: P1: (the apparent one) Sergei's new code doesn't produce error when passed a Field_null object.
P2: (less apparent one) Why do we have Microsecond changes in innodb_plugin but not in xtradb? Could there be more fixes missing in a similar way?
Sergei, could you please take a look?
BR Sergey
Hi, Lately on many occasion it happened to me to touch the innodb code (in particular related to virtual columns). And I modified the code only in storage/xtradb. All tests passed. Should I apply those changes to storage/innobase and storage innodb_pligin? How can I check that the changes do not break anything? I would appreciate if anybody clarifies this issue. Regards, Igor.
Hi!
"Igor" == Igor Babaev <igor@askmonty.org> writes:
Igor> On 06/04/2011 02:19 AM, Sergey Petrunya wrote:
Hi!
All of the recent 5.3 builds in buildbot have two failures:
innodb_plugin.innodb_bug54044 'innodb_plugin' innodb_plugin.innodb_information_schema 'innodb_plugin'
<cut> Igor> Hi, Igor> Lately on many occasion it happened to me to touch the innodb code (in Igor> particular related to virtual columns). And I modified the code only Igor> in storage/xtradb. All tests passed. Igor> Should I apply those changes to storage/innobase and storage Igor> innodb_pligin? How can I check that the changes do not break anything? Please do it at least in innodb_plugin. (Innodb is not that important as it's not part of future MySQL versions anyway.= Igor> I would appreciate if anybody clarifies this issue. Regards, Monty
Hi, Sergey! On Jun 04, Sergey Petrunya wrote:
All of the recent 5.3 builds in buildbot have two failures:
innodb_plugin.innodb_bug54044 'innodb_plugin' innodb_plugin.innodb_information_schema 'innodb_plugin'
The failure happens only with innodb_plugin. XtraDB is fine.
I've investigated the first problem. Its cause is in storage/xtradb/handler/ha_innodb.cc:get_innobase_type_from_mysql_type():
- On 2010-08-04, Kristian did a merge from XtraDB in Percona-Server-5.1.47-11 and among everything else pulled in the code that will produce error when the function's argument is Field_null. This seems to be the bugfix for BUG#54044
- On 2011-03-29, Sergei was making fix for lp:743017 in 5.1-micro, switched the function from analyzing field->type() to analyzing field->key_type() and in the process removed the part of code that Kristian has added. For some reason, he did that storage/innodb_plugin and storage/innobase but not to storage/xtradb.
Because my patch was in mysql-5.1, there was no xtradb there :)
- On May, 28th Monty has merged in Sergei's change into 5.3-main and we started to get the failure.
I see two problems here: P1: (the apparent one) Sergei's new code doesn't produce error when passed a Field_null object.
intentionally. I've fixed the test too, btw (in 5.1).
P2: (less apparent one) Why do we have Microsecond changes in innodb_plugin but not in xtradb? Could there be more fixes missing in a similar way?
Monty merged my changes into 5.3, but missed this particular detail, so xtradb and the test case were merged incorrectly. I can fix it on Monday (hopefully). Regards, Sergei
participants (4)
-
Igor Babaev -
Michael Widenius -
Sergei Golubchik -
Sergey Petrunya