[Maria-developers] Some patches for the C client library
While I was creating Debian packages for the "MariaDB Client Library for C" I came across several minor issues that I corrected. I thought I'd post the patches here in case you might be interested in integrating them; I'd have no problem with contributing them under the MCA if that's necessary (i.e. if they're even big enough to require such a thing). Each one has a fairly complete description of its purpose at the start. I've also noticed that mariadb_config --libs prints out something like ... -l-lz if WITH_EXTERNAL_ZLIB=ON. However, for the Debian packages I instead patched mariadb_config to remove the indirect dependencies altogether, as we generally do, so I didn't write a fix for the -l-lz issue. Also, it seems that if I try to build with WITH_SQLITE=ON then I get a build error, so I haven't enabled that in the Debian packages. -- Daniel Schepler
Hi Daniel, I dd some changes in rev. 159 (Nov 4th) - can you please check if they will fit your requirements? Don't care about sqlite - we will remove it soon. /Georg On Sun, Nov 23, 2014 at 4:47 PM, Daniel Schepler <dschepler@gmail.com> wrote:
While I was creating Debian packages for the "MariaDB Client Library for C" I came across several minor issues that I corrected. I thought I'd post the patches here in case you might be interested in integrating them; I'd have no problem with contributing them under the MCA if that's necessary (i.e. if they're even big enough to require such a thing). Each one has a fairly complete description of its purpose at the start.
I've also noticed that mariadb_config --libs prints out something like ... -l-lz if WITH_EXTERNAL_ZLIB=ON. However, for the Debian packages I instead patched mariadb_config to remove the indirect dependencies altogether, as we generally do, so I didn't write a fix for the -l-lz issue. Also, it seems that if I try to build with WITH_SQLITE=ON then I get a build error, so I haven't enabled that in the Debian packages. -- Daniel Schepler
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
On Fri, Nov 28, 2014 at 11:43 AM, Georg Richter <holzboote@googlemail.com> wrote:
Hi Daniel,
I dd some changes in rev. 159 (Nov 4th) - can you please check if they will fit your requirements? Don't care about sqlite - we will remove it soon.
As far as I can see, it isn't quite flexible enough - we need the libraries to go to e.g. /usr/lib/x86_64-linux-gnu, while the headers should probably still go to /usr/include/mariadb. -- Daniel Schepler
participants (2)
-
Daniel Schepler
-
Georg Richter