[Maria-developers] Patch to build xtradb and federatedx statically on Windows
Hi everyone, Recently, we found out that xtradb and federatedx were compiled as plugins on Windows. This is not correct because they are core storage engines and should be linked statically instead. On Unix, it's possible to build both types, but the CMake files doesn't really handle this. They just look in plug.in, and if there is a dynamic line, the storage engine is built dynamically. I'm hesitant to fix this properly, as it's probably already done in MySQL 5.5, or at least it will be. I see no reason to come up with a good solution for a temporary problem - there are many other issues on Windows that are more pressing. FederatedX couldn't compile as a statically linked plugin at all on Windows. I have fixed this now, but I *really* don't like the way we do these hacks on Windows. It's absurdly difficult to keep track of when a variable says xtradb and when it says innobase. And debugging CMakeLists.txt files is not too much fun. Anyway, I did the same thing on FederatedX as is done in XtraDB, and it works now. Finally, I removed a subdir that didn't have a CMakeLists.txt. Removed a warning during the cmake run. With this patch, the Windows zip file release build should work correctly and produce a MariaDB with both XtraDB and FederatedX in it. Should I check this into ~maria-captains/maria/5.1, or is there a branch more suitable at the moment? Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible.
Hi, Bo! On Jun 09, Bo Thorsen wrote:
Hi everyone,
Recently, we found out that xtradb and federatedx were compiled as plugins on Windows. This is not correct because they are core storage engines and should be linked statically instead.
Heh, that's funny. Because yesterday on the call we discussed that these engines should be built dynamically on linux :) Regards, Sergei
Den 09-06-2010 10:42, Sergei Golubchik skrev:
Hi, Bo!
On Jun 09, Bo Thorsen wrote:
Hi everyone,
Recently, we found out that xtradb and federatedx were compiled as plugins on Windows. This is not correct because they are core storage engines and should be linked statically instead.
Heh, that's funny. Because yesterday on the call we discussed that these engines should be built dynamically on linux :)
Great timing :) I can put a todo note on this part of the patch saying it should be removed later as part of the clean up you are working on with plugin loading. Bo Thorsen. Monty Program AB. -- MariaDB: MySQL replacement Community developed. Feature enhanced. Backward compatible.
participants (2)
-
Bo Thorsen
-
Sergei Golubchik