[Maria-developers] Fix for 2 failing tests on Windows
Hello, Some tests that call mtr.add_suppression to ignore expected warnings hard-code the forward slash '/' character as the expected path delimiter. This breaks tests on Windows as the regex does not match as expected. E.g. Recovering table: './mysqltest/t_corrupted2' fails to match 100123 23:48:26 [Warning] Recovering table: '.\mysqltest\t_corrupted2' and hence the test fails spuriously. Attached is a simple patch that fixes this issue while maintaining compatibility with other platforms. Let me know what you think. - Alex PS. From the Windows buildbot test logs[1], only these two tests are observed to fail in this way. [1] http://askmonty.org/buildbot/builders/win32-tarball/builds/238/steps/test/lo...
Alex Budovski <abudovski@gmail.com> writes:
Some tests that call mtr.add_suppression to ignore expected warnings hard-code the forward slash '/' character as the expected path delimiter. This breaks tests on Windows as the regex does not match as expected.
E.g.
Recovering table: './mysqltest/t_corrupted2'
fails to match
100123 23:48:26 [Warning] Recovering table: '.\mysqltest\t_corrupted2'
and hence the test fails spuriously.
Attached is a simple patch that fixes this issue while maintaining compatibility with other platforms.
Let me know what you think.
Good catch, thanks! I will incorporate this together with the binlog test fixes when I solve the problem with test failures. Is there any special reason you added --disable_query_log around the suppression calls, or was it just to avoid having to edit the .result? (Just curious, agree that there is little use in having them in .result in the first place). - Kristian.
On Tue, Jan 26, 2010 at 8:52 PM, Kristian Nielsen <knielsen@knielsen-hq.org> wrote:
Alex Budovski <abudovski@gmail.com> writes:
Some tests that call mtr.add_suppression to ignore expected warnings hard-code the forward slash '/' character as the expected path delimiter. This breaks tests on Windows as the regex does not match as expected.
E.g.
Recovering table: './mysqltest/t_corrupted2'
fails to match
100123 23:48:26 [Warning] Recovering table: '.\mysqltest\t_corrupted2'
and hence the test fails spuriously.
Attached is a simple patch that fixes this issue while maintaining compatibility with other platforms.
Let me know what you think.
Good catch, thanks!
I will incorporate this together with the binlog test fixes when I solve the problem with test failures.
Which are you referring to, out of curiousity? (Link?)
Is there any special reason you added --disable_query_log around the suppression calls, or was it just to avoid having to edit the .result? (Just curious, agree that there is little use in having them in .result in the first place).
That's the reason indeed. They're not part of the test output we're concerned with. Cheers, Alex
Alex Budovski <abudovski@gmail.com> writes:
On Tue, Jan 26, 2010 at 8:52 PM, Kristian Nielsen <knielsen@knielsen-hq.org> wrote:
Alex Budovski <abudovski@gmail.com> writes:
Some tests that call mtr.add_suppression to ignore expected warnings hard-code the forward slash '/' character as the expected path delimiter. This breaks tests on Windows as the regex does not match as expected.
E.g.
Recovering table: './mysqltest/t_corrupted2'
fails to match
100123 23:48:26 [Warning] Recovering table: '.\mysqltest\t_corrupted2'
and hence the test fails spuriously.
Attached is a simple patch that fixes this issue while maintaining compatibility with other platforms.
Let me know what you think.
Good catch, thanks!
I will incorporate this together with the binlog test fixes when I solve the problem with test failures.
Which are you referring to, out of curiousity? (Link?)
I pushed this into revision 2793 of branch mariadb-5.1-knielsen: https://askmonty.org/buildbot/grid?branch=mariadb-5.1-knielsen&length=1 As can be seen, there are many test failures in that revision. Here is a database report of them all: http://askmonty.org/buildbot/reports/cross_reference#branch=mariadb-5.1-knielsen&revision=2793&platform=&dt=&bbnum=&typ=&info=&fail_name=&fail_variant=&fail_info_short=&fail_info_full=&limit=100 - Krsitian.
Hi!
"Alex" == Alex Budovski <abudovski@gmail.com> writes:
Alex> Hello, Alex> Some tests that call mtr.add_suppression to ignore expected warnings Alex> hard-code the forward slash '/' character as the expected path Alex> delimiter. This breaks tests on Windows as the regex does not match as Alex> expected. Alex> E.g. Alex> Recovering table: './mysqltest/t_corrupted2' Alex> fails to match Alex> 100123 23:48:26 [Warning] Recovering table: '.\mysqltest\t_corrupted2' Alex> and hence the test fails spuriously. Alex> Attached is a simple patch that fixes this issue while maintaining Alex> compatibility with other platforms. Alex> Let me know what you think. Looks good; I picked this up from you tree as part of my previous review and it will be part of the push to 5.1 later today. Thanks! Regards, Monty
participants (3)
-
Alex Budovski -
Kristian Nielsen -
Michael Widenius