[Maria-developers] Your push broke windows builds on 5.3
Hi Serg, Your latest push into 5.3 broke compilation on Windows: http://buildbot.askmonty.org/buildbot/builders/win2008r2-vs2010-i386-package... http://buildbot.askmonty.org/buildbot/builders/win32-debug2/builds/734/steps... Could you please fix it? (If you don't have any idea what could be the cause, maybe Wlad could help us?) BR Sergey -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog
Hi, Sergei! On Oct 11, Sergei Petrunia wrote:
Hi Serg,
Your latest push into 5.3 broke compilation on Windows:
http://buildbot.askmonty.org/buildbot/builders/win2008r2-vs2010-i386-package...
http://buildbot.askmonty.org/buildbot/builders/win32-debug2/builds/734/steps...
Could you please fix it? (If you don't have any idea what could be the cause, maybe Wlad could help us?)
Yes, I've noticed this, but I assumed it was some kind of a local failure, like out of disk space or something. As I didn't touch comp_err.c, and the build worked ok on my windows VM and in buildbox in 5.2 and 5.1 trees. But indeed, last 5.2 build just succeeded, after 5.3 build failed (on win32-debug2), so it looks like something in the tree. I'll try to fix it. Regards, Sergei
There is a bunch of "Freeing NULL pointer at line 405, 'comp_err.c'" messages in the build log. My wild guess was safemalloc, and indeed, a merge from 5.1-feedbqack (re)introduced unconditional -DSAFEMALLOC in debug builds. I removed it again now from 5.1-5.2-5.3, and it builds fine. I presume safemalloc builds if we do any at would have this problem. Why freeing NULL pointer is bad I do not know, in C standard library it is ok.
-----Original Message----- From: Sergei Petrunia [mailto:psergey@askmonty.org] Sent: Dienstag, 11. Oktober 2011 19:42 To: Sergei Golubchik Cc: maria-developers@lists.launchpad.net; wlad@montyprogram.com Subject: Your push broke windows builds on 5.3
Hi Serg,
Your latest push into 5.3 broke compilation on Windows:
http://buildbot.askmonty.org/buildbot/builders/win2008r2-vs2010-i386- packages/builds/273/steps/build_zip/logs/stdio
http://buildbot.askmonty.org/buildbot/builders/win32- debug2/builds/734/steps/build/logs/stdio
Could you please fix it? (If you don't have any idea what could be the cause, maybe Wlad could help us?)
BR Sergey -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog
Hi, Vladislav! On Oct 11, Vladislav Vaintroub wrote:
There is a bunch of "Freeing NULL pointer at line 405, 'comp_err.c'" messages in the build log. My wild guess was safemalloc, and indeed, a merge from 5.1-feedbqack (re)introduced unconditional -DSAFEMALLOC in debug builds. I removed it again now from 5.1-5.2-5.3, and it builds fine. I presume safemalloc builds if we do any at would have this problem. Why freeing NULL pointer is bad I do not know, in C standard library it is ok.
I've fixed comp_err.c too. Regards, Sergei
participants (3)
-
Sergei Golubchik -
Sergei Petrunia -
Vladislav Vaintroub