Re: [Maria-developers] [Commits] Rev 4398: MDEV-7368 : SLES: Failed to start mysql.service: Unit
Hi, Nirbhay! On Dec 23, Nirbhay Choubey wrote:
At lp:~maria-captains/maria/5.5
------------------------------------------------------------ revno: 4398 revision-id: nirbhay@mariadb.com-20141224033207-8lh5i8d84qsjey79 parent: elenst@montyprogram.com-20141223172123-pkfhjnv7oy1suxpa committer: Nirbhay Choubey <nirbhay@mariadb.com> branch nick: b7368-5.5 timestamp: Tue 2014-12-23 22:32:07 -0500 message: MDEV-7368 : SLES: Failed to start mysql.service: Unit mysql.service failed to load
Added 'systemctl daemon-reload' command in postin and postun rpm scripts.
=== modified file 'support-files/rpm/server-postin.sh' --- a/support-files/rpm/server-postin.sh 2013-11-20 11:18:46 +0000 +++ b/support-files/rpm/server-postin.sh 2014-12-24 03:32:07 +0000 @@ -1,6 +1,10 @@
# Make MySQL start/shutdown automatically when the machine does it. if [ $1 = 1 ] ; then + if [ -x /usr/bin/systemctl ] ; then + /usr/bin/systemctl daemon-reload >/dev/null 2>&1 + fi +
looks ok
if [ -x /sbin/chkconfig ] ; then /sbin/chkconfig --add mysql fi @@ -51,30 +55,31 @@ SETARGETDIR=/etc/selinux/targeted/src/policy SEDOMPROG=$SETARGETDIR/domains/program SECONPROG=$SETARGETDIR/file_contexts/program
+if [ -f /etc/redhat-release ] ; then + if grep -q "Red Hat Enterprise Linux .. release 4" /etc/redhat-release \ + || grep -q "CentOS release 4" /etc/redhat-release ; then
I'd rather written if grep -Eqs '(Red Hat Enterprise Linux ..|CentOS) release 4' /etc/redhat-release; then or (which is more portable, but perhaps unnecessary so for an rpm postin script) if grep '\(Red Hat Enterprise Linux ..\|CentOS\) release 4' /etc/redhat-release >/dev/null 2>&1; then but if you'd like you can push your variant. Regards, Sergei
Hi Nirbhay! ----- Original Message -----
Hi, Nirbhay!
On Dec 23, Nirbhay Choubey wrote:
At lp:~maria-captains/maria/5.5
------------------------------------------------------------ revno: 4398 revision-id: nirbhay@mariadb.com-20141224033207-8lh5i8d84qsjey79 parent: elenst@montyprogram.com-20141223172123-pkfhjnv7oy1suxpa committer: Nirbhay Choubey <nirbhay@mariadb.com> branch nick: b7368-5.5 timestamp: Tue 2014-12-23 22:32:07 -0500 message: MDEV-7368 : SLES: Failed to start mysql.service: Unit mysql.service failed to load
Added 'systemctl daemon-reload' command in postin and postun rpm scripts.
=== modified file 'support-files/rpm/server-postin.sh' --- a/support-files/rpm/server-postin.sh 2013-11-20 11:18:46 +0000 +++ b/support-files/rpm/server-postin.sh 2014-12-24 03:32:07 +0000 @@ -1,6 +1,10 @@
# Make MySQL start/shutdown automatically when the machine does it. if [ $1 = 1 ] ; then + if [ -x /usr/bin/systemctl ] ; then + /usr/bin/systemctl daemon-reload >/dev/null 2>&1 + fi +
looks ok
I'm assuming SLES follows the same rules as openSUSE https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines prescribes %pre %service_add_pre mysql.service %post %service_add_post mysql.service %preun %service_del_preun mysql.service %postun %service_del_postun mysql.service I'd assume this handles any daemon reload as required otherwise something along those lines would of been mentioned. Still a little confused as mysqld.service comes from as it doesn't appear to be ./packaging/rpm-oel/mysqld.service also https://mariadb.atlassian.net/browse/MDEV-5536 is there with a fair bit of systemd work (but not much in the way of rpm spec changes). -- -- Daniel Black, Engineer @ Open Query (http://openquery.com.au) Remote expertise & maintenance for MySQL/MariaDB server environments.
participants (2)
-
Daniel Black
-
Sergei Golubchik