[Maria-developers] Review of Debian packaging file listing?
Hello! I recently updated my build scripts to automatically generate a file listing for each commit in in the Debian packaging "pool" I have. Here is a recent one: http://labs.seravo.fi/~otto/mariadb-repo/mariadb-10.0-sid-amd64/filelist-ec0... It is now very easy to review and track what files are in what package. Could somebody please quickly review that file and tell me if you spot: - any files in wrong package and should be moved? - any package that has too few files and maybe something missing? - any file attributes that might be wrong or insecure? - should any of the MariaDB plugins deserve to be shipped as a separate package? (apart from current connect and oqgraph) -- Check out our blog at http://seravo.fi/blog and follow @ottokekalainen
----- Original Message -----
Hello!
I recently updated my build scripts to automatically generate a file listing for each commit in in the Debian packaging "pool" I have.
Here is a recent one: http://labs.seravo.fi/~otto/mariadb-repo/mariadb-10.0-sid-amd64/filelist-ec0...
It is now very easy to review and track what files are in what package.
Is this still the plan? https://wiki.debian.org/Teams/MySQL/WhichPackage
Could somebody please quickly review that file and tell me if you spot: - any files in wrong package and should be moved?
mariadb-client-10.0 has mysqldumpslow and its manpage along with a lot of other execs scheduled for mysql-server-utils Didn't check the rest of the WhichPackage plan since it didn't seem to be done.
- any package that has too few files and maybe something missing?
libmariadbd-dev doesn't seem to contain any .h files or mariadb_config/mysql_config mariadb-test-10.0 lrwxrwxrwx root/root ./usr/share/mysql/mysql-test/mysql-test-run lrwxrwxrwx root/root ./usr/share/mysql/mysql-test/mtr Not sure why these aren't in /usr/bin
- any file attributes that might be wrong or insecure?
Not that I could see.
- should any of the MariaDB plugins deserve to be shipped as a separate package? (apart from current connect and oqgraph)
I'd see a need to split them when extra dependencies creep in to the plugin. -- Daniel Black, Engineer @ Open Query (http://openquery.com.au) Remote expertise & maintenance for MySQL/MariaDB server environments.
2014-12-21 23:52 GMT+02:00 Daniel Black <daniel.black@openquery.com>:
I recently updated my build scripts to automatically generate a file listing for each commit in in the Debian packaging "pool" I have.
Here is a recent one: http://labs.seravo.fi/~otto/mariadb-repo/mariadb-10.0-sid-amd64/filelist-ec0...
It is now very easy to review and track what files are in what package.
Is this still the plan? https://wiki.debian.org/Teams/MySQL/WhichPackage
No. Actually I never noticed such a page exists, thanks for spotting it! I added a comment to the page that it is legacy.
Could somebody please quickly review that file and tell me if you spot: - any files in wrong package and should be moved?
mariadb-client-10.0 has mysqldumpslow and its manpage along with a lot of other execs scheduled for mysql-server-utils
Didn't check the rest of the WhichPackage plan since it didn't seem to be done.
As the WhichPackage is legacy, there is at the moment no actual plan for mysql-5.6 or mariadb-10.0 to split into a server-utils package.
- any package that has too few files and maybe something missing?
libmariadbd-dev
doesn't seem to contain any .h files or mariadb_config/mysql_config
These files are in the package https://packages.debian.org/sid/amd64/libmariadb-client-lgpl-dev/filelist I however don't know how compatible these different libraries are and what headers are needed by what. In a comment to https://mariadb.atlassian.net/browse/MDEV-5482 I asked George Richter to see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770650 and comment how compatible mariadb_config and mysql_config are, but I haven't got any reply yet. Maybe I should simply make the libmariadbd-dev package to have "Depends: libmariadb-client-lgpl-dev"?
mariadb-test-10.0
lrwxrwxrwx root/root ./usr/share/mysql/mysql-test/mysql-test-run lrwxrwxrwx root/root ./usr/share/mysql/mysql-test/mtr
Not sure why these aren't in /usr/bin
Maybe mtr must be run in a top-level directory in relation to the test files? It's guess this is ok now.
As stated on MDEV-4537, innotop is included on the mariadb-client packages since 5.5 and the shipped version is an old one that has few bugs as far as i remember. From the serg comment on the MDEV it seems to be fix-planned for 10.1 but i dont know if its meaning the inclusion of an updated version or a removal of it and from https://wiki.debian.org/Teams/MySQL/WhichPackage, it should be put on a separate "innotop" package. The wheezy "mysql-client-5.5" package seems to include "innotop" as well (i havent checked which version), the mysql-client-5.6 package on Ubuntu too. As a side note, the "mysqlreport" version shipped with mariadb-client-10.0 shows two warnings when executed and the values of the slow queries log "LOG:" and the InnoDB "Reads Ahead Sql" are empty as the variable name for the first has changed and the second doesnt exist anymore (the same should happen with MySQL 5.6). I fixed these and added support for many new MariaDB features on MDEV-573, it works perfectly on MySQL 5.1, 5.5 and MariaDB 5.5 and 10.0. Another side note (you are not the maintainer for this package but its related to the topic) : Debian and Ubuntu ships "mytop" as a separate package but MariaDB have a specific mytop version which is available on the "scripts" folder of the sources as "mytop.sh" (which is an oddity as its a perl script), I updated it fixing some bugs, adding some features and I just backported all interesting modifications from the latest version shipped with Ubuntu which had many patches made since the MariaDB specific version has been forked. It is available on MDEV-4476, it works perfectly on MySQL 5.1, 5.5 and MariaDB 5.5 and 10.0 (i havent tested other versions). I listed on my last comment on the MDEV the differences that might be *problematic* between the Ubuntu shipped version (with patches applied) and mine. Le 21/12/2014 10:24, Otto Kekäläinen a écrit :
Hello!
I recently updated my build scripts to automatically generate a file listing for each commit in in the Debian packaging "pool" I have.
Here is a recent one: http://labs.seravo.fi/~otto/mariadb-repo/mariadb-10.0-sid-amd64/filelist-ec0...
It is now very easy to review and track what files are in what package.
Could somebody please quickly review that file and tell me if you spot: - any files in wrong package and should be moved? - any package that has too few files and maybe something missing? - any file attributes that might be wrong or insecure? - should any of the MariaDB plugins deserve to be shipped as a separate package? (apart from current connect and oqgraph)
2014-12-22 5:47 GMT+02:00 Jean Weisbuch <jean@phpnet.org>:
As stated on MDEV-4537, innotop is included on the mariadb-client packages since 5.5 and the shipped version is an old one that has few bugs as far as i remember. From the serg comment on the MDEV it seems to be fix-planned for 10.1 but i dont know if its meaning the inclusion of an updated version or a removal of it and from https://wiki.debian.org/Teams/MySQL/WhichPackage, it should be put on a separate "innotop" package.
Yes, the bug report is a bit unclear.
The wheezy "mysql-client-5.5" package seems to include "innotop" as well (i havent checked which version), the mysql-client-5.6 package on Ubuntu too.
The mariadb-10.0 in Debian has everything upstream has apart from the stuff in the subdirectory debian/*. That includes innotop, see http://anonscm.debian.org/cgit/pkg-mysql/mariadb-10.0.git/tree/debian/additi... I should maybe update thos three innotop files? What is the authoritative URL/repo I should pull from the latest release? Alternatively you can easily also make a pull request on the github mirror at https://github.com/ottok/mariadb-10.0 About your other comments regarding mysqreport and mytop: I don't know if there is anything I can do to improve the situation at the Debian packaging level.
Hi, Otto! -rw-r--r-- root/root ./usr/lib/x86_64-linux-gnu/libmysqld.so.18 This is pretty difficult to do perfectly. You put it in libmariadbd-dev - but it's not a file for -dev package, it's a shared library that deserve to be in libmariadbd package. But then, to be usable it generally requires errmsg.sys files and charset files. And may be, optionally, all server tools, like myisamchk, etc. In short, libmysqld.so.18 needs everything that mysqld needs (minus the datadir and 'mysql' user). In a perfect solution one would probably move mysqld from mariadb-server-core to mariadb-server-mysqld. And created libmariadbd package that depends on mariadb-server-core. -rw-r--r-- root/root ./usr/share/mysql/charsets/* these files should be in the mariadb-common package. They are used both by the server and the client library. -rw-r--r-- root/root ./etc/mysql/conf.d/oqgraph.cnf why the connect engine comes with connect.cnf while oqgraph doesn't have oqgraph.cnf? I believe all plugins that are packaged separately should have their own *.cnf files -rwxr-xr-x root/root ./usr/bin/perror I'd say that's more of a client tool, not a server one. -rw-r--r-- root/root ./usr/lib/mysql/plugin/dialog.so -rw-r--r-- root/root ./usr/lib/mysql/plugin/mysql_clear_password.so I didn't see these files anywhere. Where did you put client-side plugins? Regards, Sergei
participants (4)
-
Daniel Black
-
Jean Weisbuch
-
Otto Kekäläinen
-
Sergei Golubchik