Hi, Anel! Looks ok. Except that you have that pointless $gcc_version=~ line that I wrote about in a previous review. Did you verify that this script actually delivers meaningful results? On Oct 30, Anel Husakovic wrote:

revision-id: 85aa3f8cf66 (mariadb-10.2.39-96-g85aa3f8cf66) parent(s): afe00bb7cce author: Anel Husakovic committer: Anel Husakovic timestamp: 2021-07-29 12:42:44 +0200 message:

MDEV-26102: dgcov: add support for *.gcda.gcov.json.gz files of gcov 9.1+

Reviewed by: serg@mariadb.com

--- mysql-test/dgcov.pl | 55 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 37 insertions(+), 18 deletions(-)

diff --git a/mysql-test/dgcov.pl b/mysql-test/dgcov.pl index 2c00c64d1ff..543099c1b4c 100755 --- a/mysql-test/dgcov.pl +++ b/mysql-test/dgcov.pl @@ -62,12 +62,15 @@ my $res; + +my $gcc_version= `gcc -dumpversion`; +$gcc_version=~ s/(\d).*$/$1/;

find(\&gcov_one_file, $root); find(\&write_coverage, $root) if $opt_generate;

Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org