Re: [Maria-developers] [Commits] dc40d73: MDEV-8437 - plugin variables conflict with bootstrap
Hi, Sergey! On Nov 03, Sergey Vojtovich wrote:
revision-id: dc40d737d4af3cb0e272c58507ad54e4eb24be28 (mariadb-10.1.8-22-gdc40d73) parent(s): a574407444fc3ea93ca88afa93dc18154251bf74 committer: Sergey Vojtovich timestamp: 2015-11-03 12:08:23 +0400 message:
MDEV-8437 - plugin variables conflict with bootstrap
ok to push
Removed redundant attempt to create mysql.plugin table: - original code was supposed to INSTALL some plugins: INSERT INTO plugin VALUES ('innodb', 'ha_innodb.so'), ('federated', 'ha_federated.so'), ('blackhole', 'ha_blackhole.so'), ('archive', 'ha_archive.so');
I didn't see any INSERT's in the postinst script.
- original code was supposed to fail if mysql.plugin exists: The query sequence is supposed to be aborted if the CREATE TABLE fails due to an already existent table in which case the admin might already have chosen to remove one or more plugins. - mysql.plugin must've been created by preceeding mysql_install_db anyway
Regards, Sergei
Hi Sergei, On Thu, Nov 05, 2015 at 03:23:30PM +0100, Sergei Golubchik wrote:
Hi, Sergey!
On Nov 03, Sergey Vojtovich wrote:
revision-id: dc40d737d4af3cb0e272c58507ad54e4eb24be28 (mariadb-10.1.8-22-gdc40d73) parent(s): a574407444fc3ea93ca88afa93dc18154251bf74 committer: Sergey Vojtovich timestamp: 2015-11-03 12:08:23 +0400 message:
MDEV-8437 - plugin variables conflict with bootstrap
ok to push
Removed redundant attempt to create mysql.plugin table: - original code was supposed to INSTALL some plugins: INSERT INTO plugin VALUES ('innodb', 'ha_innodb.so'), ('federated', 'ha_federated.so'), ('blackhole', 'ha_blackhole.so'), ('archive', 'ha_archive.so');
I didn't see any INSERT's in the postinst script. Exactly! I guess these are leftovers from mysql-server scripts. I can see them in mysql-server-5.1/mysql-server-5.5/mysql-server-5.6 debian packages at least.
Thanks, Sergey
participants (2)
-
Sergei Golubchik
-
Sergey Vojtovich