7 PRs pending second approver - can somebody do it?
![](https://secure.gravatar.com/avatar/856432b5aa95727609567a91a533e0e9.jpg?s=120&d=mm&r=g)
Hi Sergei, Andrew or anyone else who wants to help, These PRs have already been approved by one reviewer 2-8 weeks ago and are pending the second reviewer to approve/merge. These indicate that Sergei's review is requested, but I guess anybody could be the second reviewer: https://github.com/MariaDB/server/pull/2169 https://github.com/MariaDB/server/pull/2671 The indicate that Andrewi's review is requested, but I guess anybody could be the second reviewer: https://github.com/MariaDB/server/pull/3100 https://github.com/MariaDB/server/pull/3120 https://github.com/MariaDB/server/pull/3125 https://github.com/MariaDB/server/pull/3142 https://github.com/MariaDB/server/pull/3154 I am sending this to the mailing list as well just to raise general awareness that while Andrew and Daniel are putting in a lot of effort to review "external" contributions, it is not enough and even approved PRs get stalled. Other core contributors should perhaps get into the habit of reviewing/approving PRs as well. If there was a rule in github.com/MariaDB/server that prevents any commits from being merged unless it has two approvals, it would both help improve the code quality AND also force core contributors to spend more time adding approvals on GitHub and thus automatically increase the likelihood that there are no one-approval PRs around for weeks and weeks without getting the second approval. - Otto
![](https://secure.gravatar.com/avatar/39b623a1559cf9c69ac3d9d4fb44e7fe.jpg?s=120&d=mm&r=g)
Hi, Otto, On Apr 07, Otto Kekäläinen wrote:
Hi Sergei, Andrew or anyone else who wants to help,
These PRs have already been approved by one reviewer 2-8 weeks ago and are pending the second reviewer to approve/merge.
These indicate that Sergei's review is requested, but I guess anybody could be the second reviewer:
https://github.com/MariaDB/server/pull/2169 https://github.com/MariaDB/server/pull/2671
No, I'd like to review these two. Not anybody. But my priority now is MDEV-33073 "always green buildbot". I can review them afterwards or between test runs. Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org
![](https://secure.gravatar.com/avatar/e18fab1d6f1fed826b8f85752dbbbec2.jpg?s=120&d=mm&r=g)
Hi Otto, On 08/04/2024 06:13, Otto Kekäläinen wrote:
https://github.com/MariaDB/server/pull/3100 https://github.com/MariaDB/server/pull/3120 https://github.com/MariaDB/server/pull/3125 https://github.com/MariaDB/server/pull/3142 https://github.com/MariaDB/server/pull/3154
To update on these, the MariaDB Server developers and I have moved all of them along further. Kind Regards -- Andrew (LinuxJedi) Hutchings Chief Contributions Officer MariaDB Foundation
participants (3)
-
Andrew Hutchings
-
Otto Kekäläinen
-
Sergei Golubchik