Re: [Maria-developers] 1cda762: MDEV-6069: Remove old logic for 3.23-to-higher upgrades from upgrade SQL scripts
Hi, Nirbhay! On Mar 17, Nirbhay Choubey wrote:
revision-id: 1cda762d3f1132e6696e1c451435746db0a1420a parent(s): b0542b78c866fb32383f759914b10f060d0e14cd committer: Nirbhay Choubey branch nick: server timestamp: 2015-03-17 11:20:49 -0400 message:
MDEV-6069: Remove old logic for 3.23-to-higher upgrades from upgrade SQL scripts
Fix for failing tests.
* Update mysql_system_tables_fix.sql to makeup the differences in system tables in 5.1.17 (main.system_mysql_db_fix50117)
I don't quite understand that. Why these ALTER TABLEs were not needed before?
* Removed system_mysql_db tests for versions 5.0.30 & 4.1.23.
ok Regards, Sergei
Hi Serg, On Thu, Mar 19, 2015 at 8:02 AM, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nirbhay!
revision-id: 1cda762d3f1132e6696e1c451435746db0a1420a parent(s): b0542b78c866fb32383f759914b10f060d0e14cd committer: Nirbhay Choubey branch nick: server timestamp: 2015-03-17 11:20:49 -0400 message:
MDEV-6069: Remove old logic for 3.23-to-higher upgrades from upgrade SQL
On Mar 17, Nirbhay Choubey wrote: scripts
Fix for failing tests.
* Update mysql_system_tables_fix.sql to makeup the differences in system tables in 5.1.17 (main.system_mysql_db_fix50117)
I don't quite understand that. Why these ALTER TABLEs were not needed before?
The system table structures in 5.1.17 were slightly different from the later 5.1 versions. While the original/main patch that I prepared was based on a later mysql/maria-5.1. These extra ALTERs would fix the differences. Best, Nirbhay
* Removed system_mysql_db tests for versions 5.0.30 & 4.1.23.
ok
Regards, Sergei
Are you referring "When upgrading to MySQL 5.1.18 or later from a previous MySQL version and scheduled events have been used, the upgrade utilities do not accommodate changes in event-related system tables. As a workaround, you can dump events before the upgrade, then restore them from the dump afterward. This issue was fixed in MySQL 5.1.20." (from http://dev.mysql.com/doc/relnotes/mysql/5.1/en/news-5-1-18.html ?? -- Peter On Thu, Mar 19, 2015 at 1:35 PM, Nirbhay Choubey <nirbhay@mariadb.com> wrote:
Hi Serg,
On Thu, Mar 19, 2015 at 8:02 AM, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nirbhay!
On Mar 17, Nirbhay Choubey wrote:
revision-id: 1cda762d3f1132e6696e1c451435746db0a1420a parent(s): b0542b78c866fb32383f759914b10f060d0e14cd committer: Nirbhay Choubey branch nick: server timestamp: 2015-03-17 11:20:49 -0400 message:
MDEV-6069: Remove old logic for 3.23-to-higher upgrades from upgrade SQL scripts
Fix for failing tests.
* Update mysql_system_tables_fix.sql to makeup the differences in system tables in 5.1.17 (main.system_mysql_db_fix50117)
I don't quite understand that. Why these ALTER TABLEs were not needed before?
The system table structures in 5.1.17 were slightly different from the later 5.1 versions. While the original/main patch that I prepared was based on a later mysql/maria-5.1. These extra ALTERs would fix the differences.
Best, Nirbhay
* Removed system_mysql_db tests for versions 5.0.30 & 4.1.23.
ok
Regards, Sergei
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
On Thu, Mar 19, 2015 at 8:49 AM, Peter Laursen <peter_laursen@webyog.com> wrote:
Are you referring
"When upgrading to MySQL 5.1.18 or later from a previous MySQL version and scheduled events have been used, the upgrade utilities do not accommodate changes in event-related system tables. As a workaround, you can dump events before the upgrade, then restore them from the dump afterward. This issue was fixed in MySQL 5.1.20." (from http://dev.mysql.com/doc/relnotes/mysql/5.1/en/news-5-1-18.html
??
Yes. That pretty much explains the main.system_mysql_db_fix50117 test. Best, Nirbhay
-- Peter
On Thu, Mar 19, 2015 at 1:35 PM, Nirbhay Choubey <nirbhay@mariadb.com> wrote:
Hi Serg,
On Thu, Mar 19, 2015 at 8:02 AM, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nirbhay!
On Mar 17, Nirbhay Choubey wrote:
revision-id: 1cda762d3f1132e6696e1c451435746db0a1420a parent(s): b0542b78c866fb32383f759914b10f060d0e14cd committer: Nirbhay Choubey branch nick: server timestamp: 2015-03-17 11:20:49 -0400 message:
MDEV-6069: Remove old logic for 3.23-to-higher upgrades from upgrade SQL scripts
Fix for failing tests.
* Update mysql_system_tables_fix.sql to makeup the differences in system tables in 5.1.17 (main.system_mysql_db_fix50117)
I don't quite understand that. Why these ALTER TABLEs were not needed before?
The system table structures in 5.1.17 were slightly different from the later 5.1 versions. While the original/main patch that I prepared was based on a later mysql/maria-5.1. These extra ALTERs would fix the differences.
Best, Nirbhay
* Removed system_mysql_db tests for versions 5.0.30 & 4.1.23.
ok
Regards, Sergei
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
participants (3)
-
Nirbhay Choubey -
Peter Laursen -
Sergei Golubchik