Re: [Maria-developers] [Commits] Rev 3657: MDEV-4127 : Export additional symbols when building RPM
Hi, Vladislav! May be you'd rather rename symbols with #define, just as redhat does? On Feb 03, Vladislav Vaintroub wrote:
At file:///H:/bzr/5.5/
------------------------------------------------------------ revno: 3657 revision-id: wlad@montyprogram.com-20130203164516-ex2ftmyca5b507g3 parent: elenst@ubuntu11.home-20130202225357-za9bglcf2ngv36xj committer: Vladislav Vaintroub <wlad@montyprogram.com> branch nick: 5.5 timestamp: Sun 2013-02-03 17:45:16 +0100 message: MDEV-4127 : Export additional symbols when building RPM, to enable both recompiling mysqli or odbc from sources in addition to drop-in replacement functionality.
The case in question is compiling mysqli from sources, that needs client_errors via ER() macro.
Previously, we exported it as mysql_client_errors (compatibly to Fedora's style symbol renaming, see MDEV-3842). However, if MariaDB header files are used when compiling mysqli, client_errors needs to be exported with its original name.
Regards, Sergei
-----Original Message----- From: commits-bounces@mariadb.org [mailto:commits- bounces@mariadb.org] On Behalf Of Sergei Golubchik Sent: Sonntag, 3. Februar 2013 18:17 To: maria-developers@lists.launchpad.net Cc: commits@mariadb.org Subject: Re: [Commits] Rev 3657: MDEV-4127 : Export additional symbols when building RPM
Hi, Vladislav!
May be you'd rather rename symbols with #define, just as redhat does?
Hi Sergei, It is possible. However, unless it is done conditionally (e.g #ifdef BUILD_MARIADB_AS_RPM), it is likely to break something (e.g odbc) on other (Debian-style) Linuxes. So I see 2 variants 1. Introduce BUILD_MARIADB_AS_RPM preprocessor constant, set to 1 if build with RPM. If BUILD_MARIADB_AS_RPM is set, do rename functions via #define , Redhat-style . 2. Export both original and renamed symbols, as in my patch. Both are ok to me. Which one would be better, what do you think?
On Feb 03, Vladislav Vaintroub wrote:
At file:///H:/bzr/5.5/
------------------------------------------------------------ revno: 3657 revision-id: wlad@montyprogram.com-20130203164516-ex2ftmyca5b507g3 parent: elenst@ubuntu11.home-20130202225357-za9bglcf2ngv36xj committer: Vladislav Vaintroub <wlad@montyprogram.com> branch nick: 5.5 timestamp: Sun 2013-02-03 17:45:16 +0100 message: MDEV-4127 : Export additional symbols when building RPM, to enable both recompiling mysqli or odbc from sources in addition to drop-in replacement functionality.
The case in question is compiling mysqli from sources, that needs client_errors via ER() macro.
Previously, we exported it as mysql_client_errors (compatibly to Fedora's style symbol renaming, see MDEV-3842). However, if MariaDB header files are used when compiling mysqli, client_errors needs to be exported with its original name.
Regards, Sergei _______________________________________________ commits mailing list commits@mariadb.org https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits
Hi, Vladislav! On Feb 03, Vladislav Vaintroub wrote:
Hi Sergei, It is possible.
However, unless it is done conditionally (e.g #ifdef BUILD_MARIADB_AS_RPM), it is likely to break something (e.g odbc) on other (Debian-style) Linuxes.
Oh, I see...
1. Introduce BUILD_MARIADB_AS_RPM preprocessor constant, set to 1 if build with RPM. If BUILD_MARIADB_AS_RPM is set, do rename functions via #define , Redhat-style . 2. Export both original and renamed symbols, as in my patch.
Both are ok to me. Which one would be better, what do you think?
ok, let's keep it your way then Regards, Sergei
participants (2)
-
Sergei Golubchik -
Vladislav Vaintroub