[Maria-developers] Squash aaed3436 MENT-651 [4/8] ALTER ONLINE TABLE
Sergei, I think all the commits starting from [4/8] ALTER ONLINE TABLE should be squashed. I will also add a better description in the commit message covering our latest discussions. I would also embed a reference to the original unsquashed branch. It seems to me as a good idea in sense of helping the reader investigate the code -- Yours truly, Nikita Malyavin
Hi, Nikita! On Nov 24, Nikita Malyavin wrote:
Sergei, I think all the commits starting from [4/8] ALTER ONLINE TABLE should be squashed.
I will also add a better description in the commit message covering our latest discussions.
I would also embed a reference to the original unsquashed branch. It seems to me as a good idea in sense of helping the reader investigate the code
What do you mean by that? Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
I mean, commits: - test progress reporting - open a read view for MVCC engines - Forbid savepoints setup while ONLINE ALTER goes on - decouple commit/rollback code from binlog hton - report progress - Add test for update after exclusive lock - MENT-651 [8/8] add versioning test - MENT-651 [7/8] add error handling - Fix running without binlog - MENT-651 [6/8] store cache managers in a list - Introduce cache flipping - follow-up refactoring - MENT-651 [4/8] ALTER ONLINE TABLE should be squashed after review On Wed, 24 Nov 2021 at 21:34, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nikita!
On Nov 24, Nikita Malyavin wrote:
Sergei, I think all the commits starting from [4/8] ALTER ONLINE TABLE should be squashed.
I will also add a better description in the commit message covering our latest discussions.
I would also embed a reference to the original unsquashed branch. It seems to me as a good idea in sense of helping the reader investigate the code
What do you mean by that?
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
-- Yours truly, Nikita Malyavin
Hi, Nikita! Sorry, I meant what did you mean by
I would also embed a reference to the original unsquashed branch. It seems to me as a good idea in sense of helping the reader investigate the code
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
I mean, I'd just put the reference to the head in the commit message, i. e. now the last commit is - test progress reporting f1af51e4 I'd add a line: See unsquashed history at f1af51e4 In the final commit message On Wed, 24 Nov 2021 at 23:50, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nikita!
Sorry, I meant what did you mean by
I would also embed a reference to the original unsquashed branch. It seems to me as a good idea in sense of helping the reader investigate the code
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
-- Yours truly, Nikita Malyavin
Hi, Nikita! I don't think it's a good idea. Old branches get deleted and garbage-collected eventually. If you think the history is important for understanding the changes - don't squash it. If you think it's not important - you don't need a reference to the unsquashed branch :) On Nov 25, Nikita Malyavin wrote:
I mean, I'd just put the reference to the head in the commit message, i. e. now the last commit is
- test progress reporting f1af51e4
I'd add a line: See unsquashed history at f1af51e4
In the final commit message
On Wed, 24 Nov 2021 at 23:50, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nikita!
Sorry, I meant what did you mean by
I would also embed a reference to the original unsquashed branch. It seems to me as a good idea in sense of helping the reader investigate the code
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
participants (2)
-
Nikita Malyavin -
Sergei Golubchik