Hi Sergei, thanks for your review. I was considering this alternative but couldn't come up with a consistent solution. Basically it will make sense only if INSTALL_LAYOUT=RPM and INSTALL_SYSCONFDIR!="/etc", probably not worthy to bother. Thanks, Sergey On Tue, Nov 19, 2013 at 05:16:32PM +0100, Sergei Golubchik wrote:

Hi, Sergey!

On Nov 18, Sergey Vojtovich wrote:

...

------------------------------------------------------------ revno: 3974 revision-id: svoj@mariadb.org-20131118114801-1kny2cvx8kpjsw7t parent: jplindst@mariadb.org-20131115132442-5d4hqg5idjta2dni committer: Sergey Vojtovich branch nick: 5.5-mdev5182 timestamp: Mon 2013-11-18 15:48:01 +0400 message: MDEV-5182 - build of 10.0.4/r3863 fails @ 'cmake' with -DINSTALL_SYSCONFDIR/-DDEFAULT_SYSCONFDIR specified

The reason for a bug is in support-files/CMakeLists.txt that tries to install files in INSTALL_SYSCONF2DIR, without checking whether this variable is actually defined.

Normally INSTALL_SYSCONF2DIR is always defined if INSTALL_SYSCONFDIR is defined, and support-files/CMakeLists.txt assumes that. But when one specifies INSTALL_SYSCONFDIR manually on the command line, this assumption might be broken.

Looks ok to me.

An alternative solution would be to define INSTALL_SYSCONF2DIR if INSTALL_SYSCONFDIR is defined.

Regards, Sergei