Hi, Sujatha! thanks! ok to push. one question below On Apr 01, Sujatha wrote:

revision-id: 9abbb589e6d (mariadb-10.5.2-531-g9abbb589e6d) parent(s): 04c7d5f1518 author: Sujatha <sujatha.sivakumar@mariadb.com> committer: Sujatha <sujatha.sivakumar@mariadb.com> timestamp: 2021-03-29 22:57:26 +0530 message:

MDEV-20220: Merge 5.7 P_S replication table 'replication_applier_status_by_worker

Step 3: ======

Preserve worker pool information on either STOP SLAVE/Error. In case STOP SLAVE is executed worker threads will be gone, hence worker threads will be unavailable. Querying the table at this stage will give empty rows. To address this case when worker threads are about to stop, due to an error or forced stop, create a backup pool and preserve the data which is relevant to populate performance schema table. Clear the backup pool upon slave start.

diff --git a/mysql-test/suite/perfschema/r/dml_handler.result b/mysql-test/suite/perfschema/r/dml_handler.result index ce4ae6bf9a3..61bbba3189e 100644 --- a/mysql-test/suite/perfschema/r/dml_handler.result +++ b/mysql-test/suite/perfschema/r/dml_handler.result @@ -12,78 +12,81 @@ Warning 1287 '<select expression> INTO <destination>;' is deprecated and will be # For each table in the performance schema, attempt HANDLER...OPEN, # which should fail with an error 1031, ER_ILLEGAL_HA. # ... ERROR HY000: Storage engine PERFORMANCE_SCHEMA of the table `performance_schema`.`replication_connection_configuration` doesn't have this option +SELECT TABLE_NAME INTO @table_name FROM table_list WHERE id=57; +HANDLER performance_schema.replication_applier_status_by_worker OPEN; +ERROR HY000: Storage engine PERFORMANCE_SCHEMA of the table `performance_schema`.`replication_applier_status_by_worker` doesn't have this option SELECT TABLE_NAME INTO @table_name FROM table_list WHERE id=56;

diff --git a/mysql-test/suite/perfschema/r/information_schema.result b/mysql-test/suite/perfschema/r/information_schema.result index 3f4a8cf6336..c0aff9bb956 100644 --- a/mysql-test/suite/perfschema/r/information_schema.result +++ b/mysql-test/suite/perfschema/r/information_schema.result @@ -59,6 +59,7 @@ performance_schema prepared_statements_instances def performance_schema replication_applier_configuration def performance_schema replication_applier_status def performance_schema replication_applier_status_by_coordinator def +performance_schema replication_applier_status_by_worker def performance_schema replication_connection_configuration def performance_schema rwlock_instances def performance_schema session_account_connect_attrs def etc, etc.

many tests showing that this commit adds a new performance_schema.replication_applier_status_by_worker table. but looking at the commit, I don't think it does. incorrectly split commits, perhaps? Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org