Re: [Maria-developers] oqgraph in mariadb - integration work
Arjen Lentz <arjen@openquery.com> writes:
On 31 Mar 2010, at 05:14, Arjen Lentz wrote:
I think we need something like %attr(644, root, root) %{_libdir}/mysql/plugin
Ok, I got it sorted out (it wasn't quite like this, but should be ok now).
So my preference would be to make it a built-in/regular as it will make adopton and subsequent use much easier.
Understand, unfortunately I am out of cycles to look into changing this (I think it requires some (probably simple) changes in at least plug.in and mysql-test-run.pl). But I personally have no strong opinion one way or the other. Anyway, the good news is I seem to have got everything sorted out. It's running in Buildbot now, and first few builds look correct on both .deb and .rpm. https://buildbot.askmonty.org/buildbot/grid?branch=mariadb-5.2-knielsen Arjen, I'll try to remember to put the packages up somewhere in case you want to check them out. So if everything looks ok to you, I will ask Serg to do second review, and hopefully things will be sorted! I'll push here once Launchpad gets back up: lp:~knielsen/maria/5.2-oqgraph - Kristian.
Hi Kristian On 31/03/2010, at 11:22 PM, Kristian Nielsen wrote:
So my preference would be to make it a built-in/regular as it will make adopton and subsequent use much easier.
Understand, unfortunately I am out of cycles to look into changing this (I think it requires some (probably simple) changes in at least plug.in and mysql-test-run.pl). But I personally have no strong opinion one way or the other.
Ya should be same as PBXT then, I should think?
Anyway, the good news is I seem to have got everything sorted out. It's running in Buildbot now, and first few builds look correct on both .deb and .rpm.
Great! thanks
https://buildbot.askmonty.org/buildbot/grid?branch=mariadb-5.2-knielsen
Arjen, I'll try to remember to put the packages up somewhere in case you want to check them out.
So if everything looks ok to you, I will ask Serg to do second review, and hopefully things will be sorted!
I'll push here once Launchpad gets back up:
lp:~knielsen/maria/5.2-oqgraph
Probably won't have time to review before I'm in Helsinki, so right now I'll defer to your and Serg's judgement on this. Technically, if the oqgraph-basic test is actually run, and passes, it's functional. The one thing that needs checking (as noted before) is a possible missing flag that makes OQGRAPH unhappy if binlog is not enabled; it *can* work without binlog so that flag can be added. oqgraph project has a bug on that which also lists what to tweak. I can do that in Helsinki or perhaps Serg can do it quickly. Regards, Arjen. -- Arjen Lentz, Exec.Director @ Open Query (http://openquery.com) Exceptional Services for MySQL at a fixed budget. Follow our blog at http://openquery.com/blog/ OurDelta: packages for MySQL and MariaDB @ http://ourdelta.org
Hi, Arjen! On Mar 31, Arjen Lentz wrote:
Hi Kristian
On 31/03/2010, at 11:22 PM, Kristian Nielsen wrote:
So my preference would be to make it a built-in/regular as it will make adopton and subsequent use much easier.
Understand, unfortunately I am out of cycles to look into changing this (I think it requires some (probably simple) changes in at least plug.in and mysql-test-run.pl). But I personally have no strong opinion one way or the other.
Ya should be same as PBXT then, I should think?
The difference is that PBXT is a general purpose storage engine, while OQGraph is a specialized one. If a new user will try to use it as a general purpose engine and hit the spot where OQGraph does not perform well, he will be annoyed and dissapointed with both OQGraph and MariaDB. On the other hand, if somebody needs the functionality of OQGraph - what makes the engine special - he can issue one INSTALL PLUGIN, it is not too difficult. In other words, I think that having it enabled by default will make the adopton easier, indeed, but it is not the kind of adoption you wanted to have for OQGraph - it's something that ends in a few minutes, leaves a bad aftertaste, and the "adopter" never comes back. It's the same with NDB in 5.1 - it is disabled by default for a reason. That's my opinion. Regards, Sergei
Hi Serg On 01/04/2010, at 12:55 AM, Sergei Golubchik wrote:
On Mar 31, Arjen Lentz wrote:
On 31/03/2010, at 11:22 PM, Kristian Nielsen wrote:
So my preference would be to make it a built-in/regular as it will make adopton and subsequent use much easier.
Understand, unfortunately I am out of cycles to look into changing this (I think it requires some (probably simple) changes in at least plug.in and mysql-test-run.pl). But I personally have no strong opinion one way or the other.
Ya should be same as PBXT then, I should think?
The difference is that PBXT is a general purpose storage engine, while OQGraph is a specialized one. If a new user will try to use it as a general purpose engine and hit the spot where OQGraph does not perform well, he will be annoyed and dissapointed with both OQGraph and MariaDB. On the other hand, if somebody needs the functionality of OQGraph - what makes the engine special - he can issue one INSTALL PLUGIN, it is not too difficult.
In other words, I think that having it enabled by default will make the adopton easier, indeed, but it is not the kind of adoption you wanted to have for OQGraph - it's something that ends in a few minutes, leaves a bad aftertaste, and the "adopter" never comes back.
It's the same with NDB in 5.1 - it is disabled by default for a reason.
That's my opinion.
And I reckon it's a good opinion, well thought through. A simple INSTALL PLUGIN is not a real hindrance, with everything else already in place. Let's do that for the upcoming time and see how it goes. Cheers, Arjen. -- Arjen Lentz, Exec.Director @ Open Query (http://openquery.com) Exceptional Services for MySQL at a fixed budget. Follow our blog at http://openquery.com/blog/ OurDelta: packages for MySQL and MariaDB @ http://ourdelta.org
participants (3)
-
Arjen Lentz -
Kristian Nielsen -
Sergei Golubchik