Re: [Maria-developers] bf2eaa7: MDEV-9382: After updating mariadb server apt-configure fails

Hi, Nirbhay! On Mar 02, Nirbhay Choubey wrote:
revision-id: bf2eaa7c1548f07ce5de13a406ff9183f082b8b3 (mariadb-10.1.12-4-gbf2eaa7) parent(s): fd741c1a12e78035dcef9a5684b530fe09cbfdde author: Nirbhay Choubey committer: Nirbhay Choubey timestamp: 2016-03-02 09:41:03 -0500 message:
MDEV-9382: After updating mariadb server apt-configure fails
When acting as a Galera receiver node, server startup may take more than 30 secs (the current default) as it has to wait for SST/IST operation to complete besides spending some time doing wsrep recovery.
In specific case of this MDEV, the server startup timedout as it took ~48 secs for the node to fully start.
A viable workaround would be to adjust the MYSQLD_STARTUP_TIMEOUT env to a higher value, but raising the default to 60 secs should fix scenarios like these.
--- debian/mariadb-server-10.1.mysql.init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/mariadb-server-10.1.mysql.init b/debian/mariadb-server-10.1.mysql.init index 9e098b4..005d0e8 100644 --- a/debian/mariadb-server-10.1.mysql.init +++ b/debian/mariadb-server-10.1.mysql.init @@ -109,7 +109,7 @@ case "${1:-''}" in /usr/bin/mysqld_safe "${@:2}" > /dev/null 2>&1 &
# 6s was reported in #352070 to be too little - for i in $(seq 1 "${MYSQLD_STARTUP_TIMEOUT:-30}"); do + for i in $(seq 1 "${MYSQLD_STARTUP_TIMEOUT:-60}"); do sleep 1
This doesn't fix much. Next time somebody will need 61 second and you'll adjust to 120? SST might take many minutes and it's not a good idea to have every user wait this long. Instead you should do what MDEV-8509 says. Add a line like [ -r /etc/default/mariadb ] && . /etc/default/mariadb then one can have a very personal setting of MYSQLD_STARTUP_TIMEOUT in /etc/default/mariadb Regards, Sergei Chief Architect MariaDB and security@mariadb.org

I forgot to create the PR for upstream as i did for Otto's repo : https://github.com/ottok/mariadb-10.0/pull/26 and https://github.com/ottok/mariadb-10.0/pull/27 These changes are already in Debian testing packages, should i create the PR or you will handle it on your side? Le 16/03/2016 20:02, Sergei Golubchik a écrit :
This doesn't fix much. Next time somebody will need 61 second and you'll adjust to 120? SST might take many minutes and it's not a good idea to have every user wait this long.
Instead you should do what MDEV-8509 says. Add a line like
[ -r /etc/default/mariadb ] && . /etc/default/mariadb
then one can have a very personal setting of MYSQLD_STARTUP_TIMEOUT in /etc/default/mariadb

Hi Jean, On Wed, Mar 16, 2016 at 4:48 PM, Jean Weisbuch <jean@phpnet.org> wrote:
I forgot to create the PR for upstream as i did for Otto's repo : https://github.com/ottok/mariadb-10.0/pull/26 and https://github.com/ottok/mariadb-10.0/pull/27 These changes are already in Debian testing packages, should i create the PR or you will handle it on your side?
I have just committed a patch. Best, Nirbhay
Le 16/03/2016 20:02, Sergei Golubchik a écrit :
This doesn't fix much. Next time somebody will need 61 second and you'll adjust to 120? SST might take many minutes and it's not a good idea to have every user wait this long.
Instead you should do what MDEV-8509 says. Add a line like
[ -r /etc/default/mariadb ] && . /etc/default/mariadb
then one can have a very personal setting of MYSQLD_STARTUP_TIMEOUT in /etc/default/mariadb
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

Hi Serg, On Wed, Mar 16, 2016 at 3:02 PM, Sergei Golubchik <serg@mariadb.org> wrote: .. cut..
diff --git a/debian/mariadb-server-10.1.mysql.init b/debian/mariadb-server-10.1.mysql.init
index 9e098b4..005d0e8 100644 --- a/debian/mariadb-server-10.1.mysql.init +++ b/debian/mariadb-server-10.1.mysql.init @@ -109,7 +109,7 @@ case "${1:-''}" in /usr/bin/mysqld_safe "${@:2}" > /dev/null 2>&1 &
# 6s was reported in #352070 to be too little - for i in $(seq 1 "${MYSQLD_STARTUP_TIMEOUT:-30}"); do + for i in $(seq 1 "${MYSQLD_STARTUP_TIMEOUT:-60}"); do sleep 1
This doesn't fix much. Next time somebody will need 61 second and you'll adjust to 120? SST might take many minutes and it's not a good idea to have every user wait this long.
Instead you should do what MDEV-8509 says. Add a line like
[ -r /etc/default/mariadb ] && . /etc/default/mariadb
then one can have a very personal setting of MYSQLD_STARTUP_TIMEOUT in /etc/default/mariadb
I was also keen on changing the default 30 secs limit to some higher value like 60 or 90 secs, so that it works for more installations by default. I will re-commit one. Best, Nirbhay
Regards, Sergei Chief Architect MariaDB and security@mariadb.org
participants (3)
-
Jean Weisbuch
-
Nirbhay Choubey
-
Sergei Golubchik