[Maria-developers] No MTR tests for --encrypt-binlog feature?
MariaDB - On 10.1 branch, grep on mysql-test for encrypt.binlog returns ./r/mysqld--help.result:180: --encrypt-binlog Encrypt binary logs (including relay logs) ./r/mysqld--help.result:1179:encrypt-binlog FALSE ./suite/sys_vars/r/sysvars_server_embedded.result:698:VARIABLE_NAME ENCRYPT_BINLOG ./suite/sys_vars/r/sysvars_server_notembedded.result:712:VARIABLE_NAME ENCRYPT_BINLOG Thus it does not look that the feature has actual tests. How do you know it works? Thanks, -- Laurynas
Hi Laurynas, On 11/11/2016 12:41 PM, Laurynas Biveinis wrote:
MariaDB -
On 10.1 branch, grep on mysql-test for encrypt.binlog returns
We have an open JIRA task for creating binlog encryption tests, it's on me. Unfortunately, it's been badly delayed due to the lack of time. Regards, Elena
./r/mysqld--help.result:180: --encrypt-binlog Encrypt binary logs (including relay logs) ./r/mysqld--help.result:1179:encrypt-binlog FALSE ./suite/sys_vars/r/sysvars_server_embedded.result:698:VARIABLE_NAME ENCRYPT_BINLOG ./suite/sys_vars/r/sysvars_server_notembedded.result:712:VARIABLE_NAME ENCRYPT_BINLOG
Thus it does not look that the feature has actual tests. How do you know it works?
Thanks,
Elena - Thanks - it must be https://jira.mariadb.org/browse/MDEV-9038, right? 2016-11-11 15:09 GMT+02:00 Elena Stepanova <elenst@montyprogram.com>:
Hi Laurynas,
On 11/11/2016 12:41 PM, Laurynas Biveinis wrote:
MariaDB -
On 10.1 branch, grep on mysql-test for encrypt.binlog returns
We have an open JIRA task for creating binlog encryption tests, it's on me. Unfortunately, it's been badly delayed due to the lack of time.
Regards, Elena
./r/mysqld--help.result:180: --encrypt-binlog Encrypt binary logs (including relay logs) ./r/mysqld--help.result:1179:encrypt-binlog FALSE ./suite/sys_vars/r/sysvars_server_embedded.result:698:VARIABLE_NAME ENCRYPT_BINLOG ./suite/sys_vars/r/sysvars_server_notembedded.result:712:VARIABLE_NAME ENCRYPT_BINLOG
Thus it does not look that the feature has actual tests. How do you know it works?
Thanks,
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
-- Laurynas
Laurynas, On 11/11/2016 03:40 PM, Laurynas Biveinis wrote:
Elena -
Thanks - it must be https://jira.mariadb.org/browse/MDEV-9038, right?
Yes, that's the one. Thanks for the nudge, I'll try to prioritize it and get it finally done. You concern is justified, the feature was somewhat tested initially, but there are no regular regression tests for it, so it can get broken. If somebody on the list wants to contribute MTR tests for the feature, please let me know, it will be much appreciated. Regards, Elena
2016-11-11 15:09 GMT+02:00 Elena Stepanova <elenst@montyprogram.com>:
Hi Laurynas,
On 11/11/2016 12:41 PM, Laurynas Biveinis wrote:
MariaDB -
On 10.1 branch, grep on mysql-test for encrypt.binlog returns
We have an open JIRA task for creating binlog encryption tests, it's on me. Unfortunately, it's been badly delayed due to the lack of time.
Regards, Elena
./r/mysqld--help.result:180: --encrypt-binlog Encrypt binary logs (including relay logs) ./r/mysqld--help.result:1179:encrypt-binlog FALSE ./suite/sys_vars/r/sysvars_server_embedded.result:698:VARIABLE_NAME ENCRYPT_BINLOG ./suite/sys_vars/r/sysvars_server_notembedded.result:712:VARIABLE_NAME ENCRYPT_BINLOG
Thus it does not look that the feature has actual tests. How do you know it works?
Thanks,
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
participants (2)
-
Elena Stepanova -
Laurynas Biveinis