Hi, Andrei! Ok to push! Thanks! On Jun 16, Andrei Elkin wrote:

...

...

...

What about RENAME? What other operations are there that don't open a table?

So RENAME is in above and all that fits to stmt_causes_implicit_commit() that is flagged CF_AUTO_COMMIT_TRANS (that involves CF_IMPLICIT_COMMIT_BEGIN). That reads every DDL, Admin, Account that are bin-logged.

I mean RENAME for temporary tables. Does it also cause an implicit commit?

Yes, it does, as any syntax whose lex lex->tmp_table() returns false here.

RENAME specifically does not have 'temporary' qualifier.

Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org