Re: [Maria-developers] Review request: mdev-4634
Hi Sergei, Please review a small patch that fixes the exact problem reported in 4634 (and nothing else). Thanks. (the other problems from the original big patch are now reported separately, with some of them already fixed). On 06/13/2013 12:08 PM, Sergei Golubchik wrote:
Hi, Alexander!
On Jun 13, Alexander Barkov wrote:
Hi, Alexander!
This looks like a lot of changes for what you explained the reason of the bug was. There will be lots of "whys" below...
The fix itself was quite small. However, an attempt to write a reasonable test case revealed a few other bugs. I just tried to fixing everything in a single patch.
I understood this and it was okay.
But I still wanted to know what change fixes what bug and what test case.
Okey. Let's do everything separately. These are separate reports for the problems found during writing a test case for 4634: https://mariadb.atlassian.net/browse/MDEV-4652 https://mariadb.atlassian.net/browse/MDEV-4653 https://mariadb.atlassian.net/browse/MDEV-4654
Here's a new one, found today: https://mariadb.atlassian.net/browse/MDEV-4651
Okay, as you prefer :)
Regards, Sergei
Hi, Alexander! Ok to push. On Jun 26, Alexander Barkov wrote:
=== modified file 'mysql-test/r/type_date.result' --- mysql-test/r/type_date.result 2013-03-17 06:41:22 +0000 +++ mysql-test/r/type_date.result 2013-06-26 11:14:20 +0000 @@ -298,3 +298,14 @@ insert t1 values ('2010-10-10 15:foobar' Warnings: Warning 1265 Data truncated for column 'f1' at row 1 drop table t1; +# +# MDEV-4634 Crash in CONVERT_TZ +# +SELECT CONVERT_TZ(GREATEST(DATE('2021-00-00'),DATE('2022-00-00')),'+00:00','+7:5');
you could've put the test in include/type_hrtime.inc and then you wouldn't need to duplucate it for all types. But whatever, as you like.
+CONVERT_TZ(GREATEST(DATE('2021-00-00'),DATE('2022-00-00')),'+00:00','+7:5')
Regards, Sergei
participants (2)
-
Alexander Barkov -
Sergei Golubchik