Re: 8e9c68b49dd: MDEV-25237 Assertion `global_system_variables.session_track_system_variables' failed in Session_sysvars_tracker::init | SIGSEGV's in __strlen_avx2 | UBSAN: runtime error: null pointer passed as argument 1, which is declared to never be null in my_strdup

15 Jul
2023
15 Jul
'23
8:57 a.m.
Hi, Sanja, ok to push. but see comments below: On Jul 15, Oleksandr Byelkin wrote:
again, if you see a bug with a very long summary, particularly if it basically makes no sense to a user - in that case, please, don't hesitate to make it shorter and more meaningful. For example "crash after setting session_track_system_variables to an invalid value"
this is such a common pattern that we have a helper for that, use my_strdup(safe_str(global_system_variables.session_track_system_variables))
it's ok, as you like. But technically you don't need an `if` here, my_free() just as free() works with NULL pointers fine.
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
663
Age (days ago)
663
Last active (days ago)
0 comments
1 participants
participants (1)
-
Sergei Golubchik