Hi, Sachin! ok to push On Mar 12, Sachin Setiya wrote:

revision-id: a4b8e0c30d1 (mariadb-10.4.3-60-ga4b8e0c30d1) parent(s): d8e4463d5dc author: sachin <sachin.setiya@mariadb.com> committer: sachin <sachin.setiya@mariadb.com> timestamp: 2019-03-12 19:29:57 +0530 message:

MDEV-18800 Server crash in instant_alter_column_possible or Assertion... `!pk->has_virtual()' failed in instant_alter_column_possible upon adding key

Hash key can't be primary key.

diff --git a/sql/sql_table.cc b/sql/sql_table.cc index 2d86035b7fd..a9c4c71331a 100644 --- a/sql/sql_table.cc +++ b/sql/sql_table.cc @@ -4179,6 +4179,7 @@ mysql_prepare_create_table(THD *thd, HA_CREATE_INFO *create_info, } if (is_hash_field_needed || (key_info->algorithm == HA_KEY_ALG_HASH && + key->type != Key::PRIMARY && key_info->flags & HA_NOSAME && !(file->ha_table_flags() & HA_CAN_HASH_KEYS ) && file->ha_table_flags() & HA_CAN_VIRTUAL_COLUMNS))

Regards, Sergei Chief Architect MariaDB and security@mariadb.org