Hello Alexey, Here's a newer version, adjusted to the latest bb-10.2-ext. Thanks! On 03/20/2017 05:20 PM, Alexander Barkov wrote:

Hello Alexey,

Thanks for your review.

Please find an updated version attached.

On 03/19/2017 08:12 PM, Alexey Botchkov wrote:

...

Hi, Alexander.

The patch is ok to push. I only have two cosmetical recommendation. 1. const Pair* find_pair() implementation belongs to sql_type.cc. A bit too long for the .h file.

Moved.

...

2. I'd create the enum {NOT_COMMUTATIVE, COMMUTATIVE} and use it as the parameter for the find_pair() and related functions. Makes code much more understandable.

As agreed on IRC, I created a new class Type_aggregator_commutative instead.

Thanks!

...

Best regards. HF

On Mon, Mar 13, 2017 at 3:41 PM, Alexander Barkov mailto:bar@mariadb.org> wrote:

Hello Alexey,

Please review a patch for MDEV-12238.

Thanks!