Re: [Maria-developers] 8790c095ab0: MDEV-21704 Add a new JSON field "version_id" into mysql.global_priv.priv

20 Feb
2020
20 Feb
'20
1:37 p.m.
Hi, Alexander! Looks ok, just one test related comment. On Feb 20, Alexander Barkov wrote:
instead of --log-error and LOAD DATA with REGEXP_REPLACE, please use something like --let SEARCH_FILE=$MYSQLTEST_VARDIR/log/mysqld.1.err --let SEARCH_PATTERN="'user' entry 'bad_.*has a wrong" --source include/search_pattern_in_file.inc this will print that there were 4 matches. Alternatively you can use four very specific SEARCH_PATTERN, one for each expected error. It's easier than what you've used, keeps the error log in one file, and doesn't run unnecessary sql on the server (otherwise debugging quickly becomes very annoying, grr, replication tests). Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
1897
Age (days ago)
1897
Last active (days ago)
0 comments
1 participants
participants (1)
-
Sergei Golubchik