Re: [Maria-developers] [Commits] 09eb231: MDEV-8762: file_key_management plugin should be disabled by default when linked statically
Hi, Jan! That's not a good idea. It'd mean that installing a plugin is not enough, it must be explicitly enabled. I don't see any reason why one should be forced to do it. I'll comment in the bugreport. On Oct 01, Jan Lindström wrote:
revision-id: 09eb23148830c53e594cfb88dcb31f1b9e42ae5e (mariadb-10.1.7-33-g09eb231) parent(s): 3a7cee05d6bac27c3c2f51afb8986c1581649bbc committer: Jan Lindström timestamp: 2015-10-01 14:27:10 +0300 message:
MDEV-8762: file_key_management plugin should be disabled by default when linked statically
--- sql/sql_plugin.cc | 1 + 1 file changed, 1 insertion(+)
diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc index 6d8268e..1d2e2d8 100644 --- a/sql/sql_plugin.cc +++ b/sql/sql_plugin.cc @@ -211,6 +211,7 @@ static struct
/* we disable few other plugins by default */ ,{ "feedback", PLUGIN_OFF } + ,{ "file_key_management", PLUGIN_OFF } };
Regards, Sergei
Hi Serg, Jan, On 01.10.2015 16:01, Sergei Golubchik wrote:
Hi, Jan!
That's not a good idea. It'd mean that installing a plugin is not enough, it must be explicitly enabled. I don't see any reason why one should be forced to do it.
My reasoning while creating the bug report is that the plugin does not have a default configuration which would allow it to work out-of-box, it still needs to be configured explicitly (by setting the key file); so, there is no gain from enabling it automatically. But if you prefer it this way, let it be so, I don't care much about this one as long as we don't link the plugin statically in our official builds, and don't anyhow suggest linking it so in documentation. Regards, Elena
I'll comment in the bugreport.
On Oct 01, Jan Lindström wrote:
revision-id: 09eb23148830c53e594cfb88dcb31f1b9e42ae5e (mariadb-10.1.7-33-g09eb231) parent(s): 3a7cee05d6bac27c3c2f51afb8986c1581649bbc committer: Jan Lindström timestamp: 2015-10-01 14:27:10 +0300 message:
MDEV-8762: file_key_management plugin should be disabled by default when linked statically
--- sql/sql_plugin.cc | 1 + 1 file changed, 1 insertion(+)
diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc index 6d8268e..1d2e2d8 100644 --- a/sql/sql_plugin.cc +++ b/sql/sql_plugin.cc @@ -211,6 +211,7 @@ static struct
/* we disable few other plugins by default */ ,{ "feedback", PLUGIN_OFF } + ,{ "file_key_management", PLUGIN_OFF } };
Regards, Sergei
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
Hi, Elena! On Oct 01, Elena Stepanova wrote:
On 01.10.2015 16:01, Sergei Golubchik wrote:
Hi, Jan!
That's not a good idea. It'd mean that installing a plugin is not enough, it must be explicitly enabled. I don't see any reason why one should be forced to do it.
My reasoning while creating the bug report is that the plugin does not have a default configuration which would allow it to work out-of-box, it still needs to be configured explicitly (by setting the key file); so, there is no gain from enabling it automatically. But if you prefer it this way, let it be so, I don't care much about this one as long as we don't link the plugin statically in our official builds, and don't anyhow suggest linking it so in documentation.
I don't see why anyone would link file_key_management plugin statically, unless he's making a special build to distribute within organization and want to have encryption enabled by default. And in this case a warning for a missing key file is indeed very much desirable. Regards, Sergei
participants (2)
-
Elena Stepanova -
Sergei Golubchik