Question about STACK_DIRETION fix removal in merge commit 6c05edf
Hi Marko! I noticed you removed from debian/rules a section that flipped -DSTACK_DIRECTION=-1/1 based on architecture in the merge commit https://github.com/MariaDB/server/commit/6c05edfdcd335b9587ba140ebef5d9b082c... Was this intentional? I am not sure, but it looks like a mistake to me, so I wanted to confirm. The code originates from cross-compilation fix in Debian in https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/f0ba31e1565fea..., which was later upstreamed to 10.5 (but not on 10.4) in https://github.com/MariaDB/server/commit/ea56841997995283f04e85e957c8d7f3159.... - Otto
Intentional - MDEV-31605 https://github.com/MariaDB/server/commit/d0abbdf56e11ccc88447c1dc80caaf355c9... The logic is moved into core, so the Debian work around isn't needed to work around the kludgy autodetermination of stack_direction.c The same logic is there, in fact it was the Debian commit that enumerated the two arches that grow up. On Tue, Nov 21, 2023 at 3:47 AM Otto Kekäläinen via developers <developers@lists.mariadb.org> wrote:
Hi Marko!
I noticed you removed from debian/rules a section that flipped -DSTACK_DIRECTION=-1/1 based on architecture in the merge commit https://github.com/MariaDB/server/commit/6c05edfdcd335b9587ba140ebef5d9b082c...
Was this intentional?
I am not sure, but it looks like a mistake to me, so I wanted to confirm.
The code originates from cross-compilation fix in Debian in https://salsa.debian.org/mariadb-team/mariadb-server/-/commit/f0ba31e1565fea...,
https://wiki.debian.org/CrossBuildPackagingGuidelines Common Problems - Running cmake instead of dh_auto_configure As you're using dh_autoconfigure - the following from an older commit shouldn't be needed. It will be set by dh_autoconfigure. -DCMAKE_SYSTEM_PROCESSOR=$(DEB_HOST_ARCH) \
which was later upstreamed to 10.5 (but not on 10.4) in https://github.com/MariaDB/server/commit/ea56841997995283f04e85e957c8d7f3159....
- Otto _______________________________________________ developers mailing list -- developers@lists.mariadb.org To unsubscribe send an email to developers-leave@lists.mariadb.org
participants (2)
-
Daniel Black
-
Otto Kekäläinen