Igor, Ok to push in the sense that the new patch cannot any more result in overflow. Both the old and new code are not equivalent. Given there is no comment, I cannot fully understand whether the change produces at least as good estimate of the record length as the old patch. Could you please add some general comment to the whole function how do we compute the field length. Timour On 27.06.2011 07:55, Igor Babaev wrote:

At file:///home/igor/maria/maria-5.3-merge-tmp/

------------------------------------------------------------ revno: 3062 revision-id: igor@askmonty.org-20110627045532-663o9eih0flql0n6 parent: igor@askmonty.org-20110625210227-kdneawayskx5jl4q committer: Igor Babaev<igor@askmonty.org> branch nick: maria-5.3-merge-tmp timestamp: Sun 2011-06-26 21:55:32 -0700 message: Fixed LP bug #801536. Ensured valid calculations of the estimates stored in JOIN_TAB::used_fieldlength.