Hi all with permission to review / add approval, This is ready to be merged into 11.5 and already has approval from Andrew, just needs one more approval: https://github.com/MariaDB/server/pull/2671 This has also one approval from Andrew, pending a second to be merged: https://github.com/MariaDB/server/pull/2169 Likewise, approved by Andrew, pending second: https://github.com/MariaDB/server/pull/2516 Additionally, this has been open for since January without any reviews: https://github.com/MariaDB/server/pull/2985 This was updated a month ago based on feedback, but hasn't gotten a re-review since: https://github.com/MariaDB/server/pull/3114 Pending re-review: https://github.com/MariaDB/server/pull/2556 - Otto
Otto, Thanks for highlighting the most important PRs! I discussed them with Andrew. As you know, his hard disk crashed so he doesn't have exact data at hand – but most of the PRs you mentioned, Andrew has already raised with SerG, allocating second reviewers. So all are in progress. Sorry for not being exact on the level of individual PRs. But 3114 is for Vicentiu, who is the expert, but he is concentrating on Vectors. Kaj Den tors 25 apr. 2024 kl 08:21 skrev Otto Kekäläinen via developers < developers@lists.mariadb.org>:
Hi all with permission to review / add approval,
This is ready to be merged into 11.5 and already has approval from Andrew, just needs one more approval: https://github.com/MariaDB/server/pull/2671
This has also one approval from Andrew, pending a second to be merged: https://github.com/MariaDB/server/pull/2169
Likewise, approved by Andrew, pending second: https://github.com/MariaDB/server/pull/2516
Additionally, this has been open for since January without any reviews: https://github.com/MariaDB/server/pull/2985
This was updated a month ago based on feedback, but hasn't gotten a re-review since: https://github.com/MariaDB/server/pull/3114
Pending re-review: https://github.com/MariaDB/server/pull/2556
- Otto _______________________________________________ developers mailing list -- developers@lists.mariadb.org To unsubscribe send an email to developers-leave@lists.mariadb.org
-- Kaj Arnö, CEO MariaDB Foundation | @mariadb_org | +358-45-1589296 | @kajarno
Hi, Otto, On Apr 24, Otto Kekäläinen via developers wrote:
Hi all with permission to review / add approval,
This is ready to be merged into 11.5 and already has approval from Andrew, just needs one more approval: https://github.com/MariaDB/server/pull/2671
For the reference, it's MDEV-33479. It cannot go into 11.5, because it missed the preview. But it's on me to review it and add to 11.6, Which I'll do after the upcoming 11.5.1 release (in early May) but before the 11.6.0 preview (mid-June).
This has also one approval from Andrew, pending a second to be merged: https://github.com/MariaDB/server/pull/2169
This is test-only change, doesn't need a preview. I'll try to review is ASAP.
Likewise, approved by Andrew, pending second: https://github.com/MariaDB/server/pull/2516
Approved.
Additionally, this has been open for since January without any reviews: https://github.com/MariaDB/server/pull/2985
For the reference, it's MDEV-30908. Same as above, will do between 11.5.1 release and 11.6.0 preview.
This was updated a month ago based on feedback, but hasn't gotten a re-review since: https://github.com/MariaDB/server/pull/3114 Pending re-review: https://github.com/MariaDB/server/pull/2556
Will get re-reviews, all reviewers are aware of pending PRs. Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org
participants (3)
-
Kaj Arnö -
Otto Kekäläinen -
Sergei Golubchik