[Maria-developers] Lack of linkage from MariaDB JIRA to commits
All, I have noticed that the MariaDB JIRA tickets are rarely linked to any specific commit which purportedly fixes them. Is there any standard at the moment for what should be done (and then it isn't followed) or is there no standard (and perhaps it should be made)? I would really like a consistent way to get to view the commits into various branches related to each MDEV issue, in a consistent way. Regards, Jeremy
hum, at least in my reported mdev that are fixed they (developers) include the commit id or at least the commit url in comments example: https://mariadb.atlassian.net/browse/MDEV-4687 Sergei Petrunia added a comment - 2013-07-25 19:48 Committed a patch. Sergei Petrunia added a comment - 2013-07-25 20:00 http://lists.askmonty.org/pipermail/commits/2013-July/005132.html
Hello, On Thu, Aug 08, 2013 at 10:49:23PM -0300, Roberto Spadim wrote:
hum, at least in my reported mdev that are fixed they (developers) include the commit id or at least the commit url in comments
example: https://mariadb.atlassian.net/browse/MDEV-4687
Sergei Petrunia added a comment - 2013-07-25 19:48 Committed a patch. Sergei Petrunia added a comment - 2013-07-25 20:00 http://lists.askmonty.org/pipermail/commits/2013-July/005132.html
Yes, I added these comments. However, there is no rule that one should make them, there are many cases where issues get fixed/closed without such comment. BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog
ops, sorry pressed enter ... but i didn't found a solution for this in projects that i work this is done at merges, one guy take care about linking commits to issue tracker, while developers try to help him with some points at source code or at comments of commits
The automatic linking is definitely possible. I worked at a company where we used svn+jira and had some post-commit hook on svn server that automatically linked commits into jira. I don't know details how this was done but I'd think this should be possible to do with launchpad too. Pavel On Fri, Aug 9, 2013 at 9:43 AM, Roberto Spadim <roberto@spadim.com.br> wrote:
ops, sorry pressed enter ... but i didn't found a solution for this in projects that i work this is done at merges, one guy take care about linking commits to issue tracker, while developers try to help him with some points at source code or at comments of commits
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
hi, IMHO, yes with hooks is possible, but here the main problem is add the issue number at commit description developers solve some issues and forget about add the issue tracker number to comment here (at my projects) we parse the commit with a php script hook, that found strings like "#SMM-1234567" (#SMM is the project name, 1234567 is the issue id), after founding the script link the commit to issue via rest api The problem occur when there's no #SMM string in commit There's no "don't commit" hook at git, at least i didn't see this here, if anyone know if there's a "don't commit" feature at bzr or git :) please share this information :) The only problem of a "most have issue tracker string", is when developers do some new features not tracked by issue tracker
Roberto, Unrelated to bzr and the current issue, but for your question about git, see: http://git-scm.com/book/en/Customizing-Git-Git-Hooks: "The commit-msg hook takes one parameter, which again is the path to a temporary file that contains the current commit message. If this script exits non-zero, Git aborts the commit process, so you can use it to validate your project state or commit message before allowing a commit to go through." Regards, Jeremy On Fri, Aug 9, 2013 at 10:02 AM, Roberto Spadim <roberto@spadim.com.br>wrote:
hi, IMHO,
yes with hooks is possible, but here the main problem is add the issue number at commit description developers solve some issues and forget about add the issue tracker number to comment
here (at my projects) we parse the commit with a php script hook, that found strings like "#SMM-1234567" (#SMM is the project name, 1234567 is the issue id), after founding the script link the commit to issue via rest api The problem occur when there's no #SMM string in commit There's no "don't commit" hook at git, at least i didn't see this here, if anyone know if there's a "don't commit" feature at bzr or git :) please share this information :) The only problem of a "most have issue tracker string", is when developers do some new features not tracked by issue tracker
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
hummm nice to know, i will try to implement this here :D at least to developers that only solve issues, it's a must have feature sometimes thanks jeremy
Hi, Jeremy! On Aug 08, Jeremy Cole wrote:
All,
I have noticed that the MariaDB JIRA tickets are rarely linked to any specific commit which purportedly fixes them. Is there any standard at the moment for what should be done (and then it isn't followed) or is there no standard (and perhaps it should be made)?
I would really like a consistent way to get to view the commits into various branches related to each MDEV issue, in a consistent way.
Right. I'd love to have a trigger that automatically links jira tickets to corresponding changesets. Let me check if we can have it... Regards, Sergei
participants (5)
-
Jeremy Cole -
Pavel Ivanov -
Roberto Spadim -
Sergei Golubchik -
Sergei Petrunia