[Maria-developers] Time to remove sql_select.cc:find_best() ?

Hi, I was looking today at some optimizer code, and bumped again into sql_select.cc:find_best(). We have been using the greedy optimizer for years, and this function has been dead code for a while, isn't it time to remove it? The less code, the better. Timour

Hi, Timour! On Jun 02, Timour Katchaounov wrote:
Hi,
I was looking today at some optimizer code, and bumped again into sql_select.cc:find_best(). We have been using the greedy optimizer for years, and this function has been dead code for a while, isn't it time to remove it?
The less code, the better.
I was removed in MySQL recently (fyi) Regards, Sergei

Sergei,
Hi, Timour!
On Jun 02, Timour Katchaounov wrote:
Hi,
I was looking today at some optimizer code, and bumped again into sql_select.cc:find_best(). We have been using the greedy optimizer for years, and this function has been dead code for a while, isn't it time to remove it?
The less code, the better.
I was removed in MySQL recently (fyi)
Great, in which version? In the trunk (5.5.) ? Timour

Hi, Timour! On Jun 02, Timour Katchaounov wrote:
Sergei,
Hi, Timour! On Jun 02, Timour Katchaounov wrote:
Hi,
I was looking today at some optimizer code, and bumped again into sql_select.cc:find_best(). We have been using the greedy optimizer for years, and this function has been dead code for a while, isn't it time to remove it?
The less code, the better. I was removed in MySQL recently (fyi)
Great, in which version? In the trunk (5.5.) ?
In mysql-next-mr-bugfixing branch http://lists.mysql.com/commits/108736 Regards, Sergei
participants (2)
-
Sergei Golubchik
-
Timour Katchaounov