Re: [Maria-developers] Rev 4323: Set proper alternative names on RHEL7: they should match Fedora names
Hi, Sergey! I cannot verify whether rhel7 alternative names should match Fedora names or they should be something different. Assuming they should match, your patch is ok. On Oct 09, Sergey Vojtovich wrote:
------------------------------------------------------------ revno: 4323 revision-id: svoj@mariadb.org-20141009112748-eq3xwoyobgnz0cxj parent: svoj@mariadb.org-20141008141031-xv2x7vrq269202vf committer: Sergey Vojtovich <svoj@mariadb.org> branch nick: 5.5 timestamp: Thu 2014-10-09 15:27:48 +0400 message: Set proper alternative names on RHEL7: they should match Fedora names. === modified file 'cmake/cpack_rpm.cmake' --- a/cmake/cpack_rpm.cmake 2014-10-08 07:35:00 +0000 +++ b/cmake/cpack_rpm.cmake 2014-10-09 11:27:48 +0000 @@ -182,7 +182,7 @@ IF(RPM MATCHES "(rhel|centos)5") ELSEIF(RPM MATCHES "(rhel|centos)6") ALTERNATIVE_NAME("client" "mysql") ALTERNATIVE_NAME("shared" "mysql-libs") -ELSEIF(RPM MATCHES "fedora") +ELSEIF(RPM MATCHES "fedora" OR RPM MATCHES "(rhel|centos)7") SET(epoch 1) # this is fedora ALTERNATIVE_NAME("client" "mariadb") ALTERNATIVE_NAME("client" "mysql")
Regards, Sergei
Hi Sergei, yum search mariadb on RHEL7 gives: mariadb-bench.ppc64 : MariaDB benchmark scripts and data mariadb-devel.ppc : Files for development of MariaDB/MySQL applications mariadb-devel.ppc64 : Files for development of MariaDB/MySQL applications mariadb-libs.ppc : The shared libraries required for MariaDB/MySQL clients mariadb-libs.ppc64 : The shared libraries required for MariaDB/MySQL clients mariadb-server.ppc64 : The MariaDB server and related files mariadb.ppc64 : A community developed branch of MySQL mariadb-test.ppc64 : The test suite distributed with MariaD There seem to be no MySQL packages. Is there anything else we should check to verify correctness of this fix? Thanks, Sergey On Thu, Oct 30, 2014 at 10:44:25AM +0100, Sergei Golubchik wrote:
Hi, Sergey!
I cannot verify whether rhel7 alternative names should match Fedora names or they should be something different.
Assuming they should match, your patch is ok.
On Oct 09, Sergey Vojtovich wrote:
------------------------------------------------------------ revno: 4323 revision-id: svoj@mariadb.org-20141009112748-eq3xwoyobgnz0cxj parent: svoj@mariadb.org-20141008141031-xv2x7vrq269202vf committer: Sergey Vojtovich <svoj@mariadb.org> branch nick: 5.5 timestamp: Thu 2014-10-09 15:27:48 +0400 message: Set proper alternative names on RHEL7: they should match Fedora names. === modified file 'cmake/cpack_rpm.cmake' --- a/cmake/cpack_rpm.cmake 2014-10-08 07:35:00 +0000 +++ b/cmake/cpack_rpm.cmake 2014-10-09 11:27:48 +0000 @@ -182,7 +182,7 @@ IF(RPM MATCHES "(rhel|centos)5") ELSEIF(RPM MATCHES "(rhel|centos)6") ALTERNATIVE_NAME("client" "mysql") ALTERNATIVE_NAME("shared" "mysql-libs") -ELSEIF(RPM MATCHES "fedora") +ELSEIF(RPM MATCHES "fedora" OR RPM MATCHES "(rhel|centos)7") SET(epoch 1) # this is fedora ALTERNATIVE_NAME("client" "mariadb") ALTERNATIVE_NAME("client" "mysql")
Regards, Sergei
Hi, Sergey! On Oct 30, Sergey Vojtovich wrote:
Hi Sergei,
yum search mariadb on RHEL7 gives:
mariadb-bench.ppc64 : MariaDB benchmark scripts and data mariadb-devel.ppc : Files for development of MariaDB/MySQL applications mariadb-devel.ppc64 : Files for development of MariaDB/MySQL applications mariadb-libs.ppc : The shared libraries required for MariaDB/MySQL clients mariadb-libs.ppc64 : The shared libraries required for MariaDB/MySQL clients mariadb-server.ppc64 : The MariaDB server and related files mariadb.ppc64 : A community developed branch of MySQL mariadb-test.ppc64 : The test suite distributed with MariaD
Looks like fedora's, yes.
There seem to be no MySQL packages. Is there anything else we should check to verify correctness of this fix?
Besides usual install/upgrade tests on RHEL7 (including tests with mariadb* packages)? No, nothing else that I can think of. Regards, Sergei
participants (2)
-
Sergei Golubchik -
Sergey Vojtovich