PRs with two approvals but not merged

Hi, Here are two PRs that have already two approvals, yet they have not been merged for many weeks. Can you please state explicitly on the PR as a comment what the submitter needs to do, or if there is nothing to do, just merge it? * https://github.com/MariaDB/server/pull/3208 * https://github.com/MariaDB/server/pull/2556 Thanks

Hi Otto, #2556 has been merged. #3208 I was confused about Sergei's review, it was approved but appeared to have outstanding comments? If Sergei really is OK with it, I'll get it landed. Kind Regards Andrew On 03/10/2024 16:00, Otto Kekäläinen via developers wrote:
Hi,
Here are two PRs that have already two approvals, yet they have not been merged for many weeks. Can you please state explicitly on the PR as a comment what the submitter needs to do, or if there is nothing to do, just merge it?
* https://github.com/MariaDB/server/pull/3208 * https://github.com/MariaDB/server/pull/2556
Thanks _______________________________________________ developers mailing list -- developers@lists.mariadb.org To unsubscribe send an email to developers-leave@lists.mariadb.org
-- Andrew (LinuxJedi) Hutchings Chief Contributions Officer MariaDB Foundation

Hi, Andrew, I've merely asked to retain the # MDEV-6975 Implement TLS protocol line. I'd prefer the contributor to do it before the PR is merged. On Oct 04, Andrew Hutchings via developers wrote:
Hi Otto,
#2556 has been merged.
#3208 I was confused about Sergei's review, it was approved but appeared to have outstanding comments? If Sergei really is OK with it, I'll get it landed.
Kind Regards Andrew
On 03/10/2024 16:00, Otto Kekäläinen via developers wrote:
Hi,
Here are two PRs that have already two approvals, yet they have not been merged for many weeks. Can you please state explicitly on the PR as a comment what the submitter needs to do, or if there is nothing to do, just merge it?
* https://github.com/MariaDB/server/pull/3208 * https://github.com/MariaDB/server/pull/2556
Thanks
Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org

Hi! Thanks for merging #2556 now! I don't think #3208 will be updated as it has no feedback stating that something *is* required to change for it to be accepted. Considering the to me passed, please just merge or reject it.
participants (3)
-
Andrew Hutchings
-
Otto Kekäläinen
-
Sergei Golubchik