Re: [Maria-developers] fcf2c5fff14: MDEV-26299: Some views force server (and mysqldump) to generate invalid SQL for their definitions
Hi, Oleksandr! On Oct 16, Oleksandr Byelkin wrote:
Where can item->name be NULL? I thought the either specified by the user or autogenerated, but never NULL.
why check_table_name() if it isn't a table? it's an incorrect check to use for columns.
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
Hi! Sergei Golubchik <serg@mariadb.org> schrieb am Sa., 16. Okt. 2021, 10:23:
Or internally created with null name.
A derived table AKA a subquery in the FROM clause is still a table. For other things I have no idea why we check AS part for correspondence to table name rules, but we do it on parsing.
Hi, Oleksandr!
Do you have an example of such internally created with null name item?
A derived table is still a table. But item->name isn't a name of a defived, it's a name of the item. check_table_name is just incorrect there, it will reject valid column names and will accept invalid column names. A check_column_name function exists for a reason :) Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
participants (2)
-
Oleksandr Byelkin
-
Sergei Golubchik