PR#2779: Fix merge commit 5ea5291: No test file or result files should be executable
![](https://secure.gravatar.com/avatar/856432b5aa95727609567a91a533e0e9.jpg?s=120&d=mm&r=g)
Hi Sanja! Did you notice my PR https://github.com/MariaDB/server/pull/2779? I tagged you about a minor bug in you previous merge. I was hoping you would notice it and review that PR, but Daniel Black jumped on it. I am asking now because it seems the exact same thing happened for mysql-test/main/lowercase_table2.result in your commit fecd78b8378 from November 8th, so I thought I'd send an extra email now to ensure you are aware of this happening. - Otto
![](https://secure.gravatar.com/avatar/ff779c7bded6dec5af8c46f41eea1c0b.jpg?s=120&d=mm&r=g)
Hi, Otto.
It looks a but more than a simple one, I will reassign The PR to more the
suitable man to decide.
On Mon, Nov 20, 2023 at 6:01 PM Otto Kekäläinen
Hi Sanja!
Did you notice my PR https://github.com/MariaDB/server/pull/2779?
I tagged you about a minor bug in you previous merge. I was hoping you would notice it and review that PR, but Daniel Black jumped on it.
I am asking now because it seems the exact same thing happened for mysql-test/main/lowercase_table2.result in your commit fecd78b8378 from November 8th, so I thought I'd send an extra email now to ensure you are aware of this happening.
- Otto
![](https://secure.gravatar.com/avatar/856432b5aa95727609567a91a533e0e9.jpg?s=120&d=mm&r=g)
Hi Sanja!
The PR is already merged. The point is just that you should read it
yourself, fix mysql-test/main/lowercase_table2.result yourself now (so
that I don't have to send a PR for it), and try to avoid making the
same mistake again.
There seems to be something going on in your merge workflow that makes
files executable (chmod +x) in vain. Also the way you review your
commits makes you omit seeing the git output that tells you that file
permissions have changed.
I recommend using e.g. `gitk --all` to visualize the contents of git commits.
On Tue, 21 Nov 2023 at 04:57, Oleksandr Byelkin
Hi, Otto.
It looks a but more than a simple one, I will reassign The PR to more the suitable man to decide.
On Mon, Nov 20, 2023 at 6:01 PM Otto Kekäläinen
wrote: Hi Sanja!
Did you notice my PR https://github.com/MariaDB/server/pull/2779?
I tagged you about a minor bug in you previous merge. I was hoping you would notice it and review that PR, but Daniel Black jumped on it.
I am asking now because it seems the exact same thing happened for mysql-test/main/lowercase_table2.result in your commit fecd78b8378 from November 8th, so I thought I'd send an extra email now to ensure you are aware of this happening.
- Otto
![](https://secure.gravatar.com/avatar/856432b5aa95727609567a91a533e0e9.jpg?s=120&d=mm&r=g)
Hi Sanja!
Just checking, did you notice this message?
The change you did by accident on
mysql-test/main/lowercase_table2.result is still not reverted.
I was hoping you could fix it so I don't have to file a pull request
for such a small thing, and also it is important you acknowledge you
understand what happened so you don't accidentally repeat the same
mistake a third time.
Thanks!
On Wed, 22 Nov 2023 at 07:44, Otto Kekäläinen
Hi Sanja!
The PR is already merged. The point is just that you should read it yourself, fix mysql-test/main/lowercase_table2.result yourself now (so that I don't have to send a PR for it), and try to avoid making the same mistake again.
There seems to be something going on in your merge workflow that makes files executable (chmod +x) in vain. Also the way you review your commits makes you omit seeing the git output that tells you that file permissions have changed.
I recommend using e.g. `gitk --all` to visualize the contents of git commits.
On Tue, 21 Nov 2023 at 04:57, Oleksandr Byelkin
wrote: Hi, Otto.
It looks a but more than a simple one, I will reassign The PR to more the suitable man to decide.
On Mon, Nov 20, 2023 at 6:01 PM Otto Kekäläinen
wrote: Hi Sanja!
Did you notice my PR https://github.com/MariaDB/server/pull/2779?
I tagged you about a minor bug in you previous merge. I was hoping you would notice it and review that PR, but Daniel Black jumped on it.
I am asking now because it seems the exact same thing happened for mysql-test/main/lowercase_table2.result in your commit fecd78b8378 from November 8th, so I thought I'd send an extra email now to ensure you are aware of this happening.
- Otto
participants (2)
-
Oleksandr Byelkin
-
Otto Kekäläinen