[Maria-developers] [GSoC] Request for code review
Hi Sergei, This is Shuang, a participant for GSoC 2013 Kerberize MariaDB project. I want to ask the community to review the code before requesting for pull and send the MCA. How could I send the codes? In a diff file? or from other approaches? Thank you very much and best regards! Sincerely, Shuang
Hi, QIU! On Sep 27, QIU Shuang wrote:
This is Shuang, a participant for GSoC 2013 Kerberize MariaDB project. I want to ask the community to review the code before requesting for pull and send the MCA. How could I send the codes? In a diff file? or from other approaches?
Do you have a tree on launchpad with your code? Then the easiest way would be to propose a merge of your tree into mariadb. See https://help.launchpad.net/Code/Review Besides you should submit the MCA or put your code under a New BSD License before the review, not after. Regards, Sergei
Hi Sergei,
Do you have a tree on launchpad with your code? Yes, I have. Here is the URL to my branch: https://code.launchpad.net/~qiush-summer/maria/krb_auth_plugin.
Then the easiest way would be to propose a merge of your tree into mariadb. See https://help.launchpad.net/Code/Review I've submitted my merging proposal following the instructions step by step while leaving the requested reviewer empty, since I don't know who are experts in community on this topic. Thank you if you could help :).
Besides you should submit the MCA or put your code under a New BSD License before the review, not after. I'll send the MCA later soon to the community.
Thank you for your time and concern and best regards! Sincerely, Shuang On Sep 27, 2013, at 9:18 PM, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, QIU!
On Sep 27, QIU Shuang wrote:
This is Shuang, a participant for GSoC 2013 Kerberize MariaDB project. I want to ask the community to review the code before requesting for pull and send the MCA. How could I send the codes? In a diff file? or from other approaches?
Do you have a tree on launchpad with your code? Then the easiest way would be to propose a merge of your tree into mariadb. See https://help.launchpad.net/Code/Review
Besides you should submit the MCA or put your code under a New BSD License before the review, not after.
Regards, Sergei
participants (2)
-
QIU Shuang
-
Sergei Golubchik