[Maria-developers] MDEV-4309: Review for 201402181003_sanja_copy_calls_patch.diff

25 Feb
2014
25 Feb
'14
2:09 p.m.
Hi Sanja, My input for 201402181003_sanja_copy_calls_patch.diff: * memcpy_field_possible() should have a function comment mentioning that it checks whether memcpy_field_value() can be used. * field_conv_incompatible() should have a function comment mentioning that it is a function that is used instead of field_conv() when we know in advance that memcpy_field_possible(...)==false. Ok to push after this is addressed. BR Sergei -- Sergei Petrunia, Software Developer MariaDB | Skype: sergefp | Blog: http://s.petrunia.net/blog
4017
Age (days ago)
4017
Last active (days ago)
0 comments
1 participants
participants (1)
-
Sergey Petrunia